You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Styling with <details role="list"> breaks accessibility because the list role requires that children have the listitem role. [spec]
My suggestion:
Either avoid using aria roles for styling, or
Use role="group" on the ul element, which is accepted by the spec, passes Lighthouse, and also doesn't make a difference on the dropdown style. I can't tell whether this makes sense for accessibility.
The role="group" solution is pretty much a workaround that's good enough for me, but it might be worth filing an Issue for this.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hi, I'm testing Pico with Lighthouse and found an accessibility issue with the Dropdown. As per the documentation:
Styling with
<details role="list">
breaks accessibility because thelist
role requires that children have thelistitem
role. [spec]My suggestion:
role="group"
on theul
element, which is accepted by the spec, passes Lighthouse, and also doesn't make a difference on the dropdown style. I can't tell whether this makes sense for accessibility.The
role="group"
solution is pretty much a workaround that's good enough for me, but it might be worth filing an Issue for this.Beta Was this translation helpful? Give feedback.
All reactions