CompressingReader: compressed data reader stream (#210) #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Go, `http.Request` requires an `io.ReadCloser` for an upload body. To facilitate compression of data being uploaded we want to wrap a source reader (such an `io.File`) with a proposed `lz4.CompressingReader`, whereupon the said reader can be set directly into `http.Request` Body field. This benefits not only the plain `http.Request`, but also the various network file storage APIs which build on top of Go's http client. Signed-off-by: Alex Dubov <[email protected]>
Out buffer may have some stale overflow data on Reset. Signed-off-by: Alex Dubov <[email protected]>
It is possible for out buffer to have no overflow data and yet the read offset will be not zero (if byte slices passed by the reader just happened to align perfectly). Signed-off-by: Alex Dubov <[email protected]>
|
CI reports some errors in your test file. Could you have a look? |
Looks like your go version is much older than mine. Technically, should not be a problem to go back to io/ioutil for these. |
Signed-off-by: Alex Dubov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Go,
http.Requestrequires anio.ReadCloserfor an upload body. To facilitate compression of data being uploaded we want to wrap a source reader (such anio.File) with a proposedlz4.CompressingReader, whereupon the said reader can be set directly intohttp.RequestBody field.This benefits not only the plain
http.Request, but also the various network file storage APIs which build on top of Go's http client.