Added crontab support and switched to MariaDB #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariaDB and crontab support added
typo
Minor fix - work around Debian 9 "bug" with cron and Docker.
|
It's possible to keep phpIpam image the way it was and use a docker-friendly scheduler service. I've suggested to use cron from Ofelia at #77 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes were made:
I also changed how this is built. By default now it uses docker-compose to build the container. This was done to support the changes that I made and allow the ability to update the contab file in the config directory and restart the container for the changes to take effect.
An entrypoint.sh file was added. This file will wait 90 seconds for MariaDB to be ready and either continue with initialization or quit. Once MariaDB is ready, the script will then start the cron service then execute the default entry point of docker-php-entrypoint with the argument of apache2-foreground, which starts Apache and PHP.
Additionally the database is now persistent across container rebuilds. Data from MariaDB is now kept in db_data/mysql.