Unit shift: USD2005 -> USD2017 #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
robinhasse
commented
Dec 6, 2024
robinhasse
commented
- shift to USD2017 unit
- use biomass split from mrcommons to ensure consistency
ricardarosemann
approved these changes
Dec 6, 2024
| as.quitte() %>% | ||
| as.magpie() | ||
| as.magpie() %>% | ||
| toolSplitBiomass(gdppop, dim = 3.1) %>% |
There was a problem hiding this comment.
dim = 3.1 is the default, so you could also skip this.
Comment on lines
+85
to
+88
| as.quitte() %>% | ||
| as.magpie() %>% | ||
| toolSplitBiomass(gdppop, "biomod", dim = "carrier") %>% | ||
| as.quitte() %>% |
There was a problem hiding this comment.
Maybe we could also enable toolSplitBiomass to handle both quitte and magpie obejcts? Just an idea and definitely does not have to be now.
| # DISAGGREGATE --------------------------------------------------------------- | ||
| # SAGGREGATE ----------------------------------------------------------------- |
There was a problem hiding this comment.
Probably not intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.