Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible low-code mixing of different data readers #23

Open
JakobBD opened this issue Aug 23, 2024 · 2 comments
Open

More flexible low-code mixing of different data readers #23

JakobBD opened this issue Aug 23, 2024 · 2 comments
Assignees

Comments

@JakobBD
Copy link
Collaborator

JakobBD commented Aug 23, 2024

If I want to define the items of the dimensions in the code, and read parameters from csv, I should be able to do so without complex coding.

@JakobBD JakobBD self-assigned this Aug 23, 2024
@SallyDa
Copy link
Collaborator

SallyDa commented Aug 23, 2024

See documentation for sodym.dimensions.DimensionSet, where I have explicitly added this example. Not sure if you still think it's too complicated, but I would think that having such an example in a jupyter notebook as well would be sufficient?

@SallyDa
Copy link
Collaborator

SallyDa commented Aug 23, 2024

I can see that having either more examples, or defining functions outside the datareader and then when defining your datareader you could basically take those functions from outside in whichever combination you like. Personally I still prefer to have all data reading defined in the same place (in the DataReader child you specify), but I think this links to the MFASystem discussion and how MFASystem instances should be initialised/defined and used. Maybe for a longer discussion then...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants