Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for require_started #1297

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

aurianer
Copy link
Contributor

Part of #49

@aurianer aurianer changed the title Add documentation for require_started sender adaptor Add documentation for require_started Oct 30, 2024
Copy link

codacy-production bot commented Oct 30, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.04% (target: -1.00%) (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (640c5f9) 18262 13790 75.51%
Head commit (f3fc502) 18263 (+1) 13798 (+8) 75.55% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1297) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

tools/pre-commit Outdated Show resolved Hide resolved
@aurianer aurianer force-pushed the require_started_documentation branch from b7be37f to 9ab4249 Compare November 1, 2024 07:36
@aurianer aurianer force-pushed the require_started_documentation branch 2 times, most recently from 195362a to c1bbc42 Compare November 9, 2024 23:16
@aurianer
Copy link
Contributor Author

aurianer commented Nov 9, 2024

This one should be good to go, if CI agrees..

@aurianer aurianer force-pushed the require_started_documentation branch from c1bbc42 to ee3efd9 Compare November 11, 2024 10:00
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@msimberg msimberg added this pull request to the merge queue Nov 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 11, 2024
@aurianer aurianer force-pushed the require_started_documentation branch from ee3efd9 to fc509f1 Compare November 13, 2024 20:18
@aurianer aurianer force-pushed the require_started_documentation branch from fc509f1 to f3fc502 Compare November 13, 2024 20:19
@msimberg msimberg added this pull request to the merge queue Nov 14, 2024
@msimberg msimberg removed this pull request from the merge queue due to a manual request Nov 14, 2024
@msimberg msimberg merged commit c8275ee into pika-org:main Nov 14, 2024
37 checks passed
@msimberg msimberg added this to the 0.31.0 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants