Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Ignore Repeats to work with non-consecutive notifications #95

Open
pilot51 opened this issue Dec 17, 2022 · 0 comments
Open

Improve Ignore Repeats to work with non-consecutive notifications #95

pilot51 opened this issue Dec 17, 2022 · 0 comments
Assignees
Milestone

Comments

@pilot51
Copy link
Owner

pilot51 commented Dec 17, 2022

Currently, Ignore Repeats only detects consecutive repeated notifications. This is a problem when, for example, an app is constantly reposting a notification to update a progress bar and a different notification is posted, causing Voice Notify to speak the reposted notification again after the new notification.

This will require a memory of previous spoken notifications up to the value set in Ignore Repeats. If it is set to infinite or a very high value, it could lead to issues with excessive memory usage over time. A good compromise may be to limit Ignore Repeats to something like 24 hours and/or limit the list in memory to 1000 spoken notifications, which should be as good as infinite for practically everyone and even if not, it's better at being infinite than the way it works now.
Be sure to indicate these limits in the dialog.

@pilot51 pilot51 added this to the v1.2.3 milestone Dec 17, 2022
@pilot51 pilot51 self-assigned this Dec 17, 2022
@pilot51 pilot51 modified the milestones: v1.2.3, v1.2.4 Aug 17, 2023
@pilot51 pilot51 modified the milestones: v1.2.4, v1.3.1 Jan 1, 2024
@pilot51 pilot51 modified the milestones: v1.3.1, v1.3.2 Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant