Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Allow to save Defintions with APP_DEBUG=false #531

Closed
ThomasGravel opened this issue May 11, 2022 · 11 comments
Closed

[Feature]: Allow to save Defintions with APP_DEBUG=false #531

ThomasGravel opened this issue May 11, 2022 · 11 comments
Assignees

Comments

@ThomasGravel
Copy link

Feature description

We need to save the data-hub config with APP_DEBUG=false, because the workflow engine sends emails to the user only if the APP_DEBUG=false.

We now overwrite the isWriteable function in the Configuration.php, but I think this is not the solution.

@mcop1
Copy link
Contributor

mcop1 commented May 16, 2022

Please take a look here, section "Configuration Storage Locations & Fallbacks"
https://pimcore.com/docs/pimcore/current/Development_Documentation/Deployment/Configuration_Environments.html

Does this solve your problem?

@mcop1
Copy link
Contributor

mcop1 commented Jun 8, 2022

Closed due to inactivity, feel free to reopen the issue if needed.

@mcop1 mcop1 closed this as completed Jun 8, 2022
@ThomasGravel
Copy link
Author

This does not solve our problems. We want to save and edit the data-hub on the production system with APP_DEBUG=false. We need APP_DEBUG=false, because the workflow engine does not send emails if we set APP_DEBUG=true. We have some editor users, that must have the possibility to change the settings of the data-hub.

@mcop1
Copy link
Contributor

mcop1 commented Jun 8, 2022

Did you try to set

PIMCORE_WRITE_TARGET_DATA_HUB=settings-store

in your env file?
This should make the configs writeable without APP_DEBUG=true, just like it is described in the documentation.

@mcop1 mcop1 reopened this Jun 8, 2022
@mcop1
Copy link
Contributor

mcop1 commented Jun 10, 2022

Maybe you can take a look here too
#543 (comment)

@mcop1
Copy link
Contributor

mcop1 commented Jun 20, 2022

@ThomasGravel have you been able to solve your problem?

@mcop1 mcop1 closed this as completed Jul 6, 2022
@betterapp
Copy link

betterapp commented May 10, 2024

Did you try to set

PIMCORE_WRITE_TARGET_DATA_HUB=settings-store

in your env file? This should make the configs writeable without APP_DEBUG=true, just like it is described in the documentation.

this does not work for me in PIM 11

@maxihaindl
Copy link

maxihaindl commented Jul 25, 2024

Did you try to set

PIMCORE_WRITE_TARGET_DATA_HUB=settings-store

in your env file? This should make the configs writeable without APP_DEBUG=true, just like it is described in the documentation.

Does not work for me either on Pimcore version 11.2.6

@marko91
Copy link

marko91 commented Sep 19, 2024

@mcop1 the PIMCORE_WRITE_TARGET_DATA_HUB=settings-store doesnt work anymore on the newer Pimcore versions, is there any alternative to be able to save data-importer configurations on production env while having APP_DEBUG=false

I have found that setting the below in config.yaml does enable the "Add configuration" button on the DataHub, but the existing data-importer configs cannot be saved

pimcore_data_hub:
    config_location: 
        data_hub:
            write_target:
                type: 'settings-store'

@mcop1
Copy link
Contributor

mcop1 commented Sep 19, 2024

Hello @marko91,
as far as I can see everything should be documented here and also here.

The reason for your problem could be that some configurations are stored as yaml configuration and some are stored in the settings store. If you set the write_target to the settings store, then you are not able to save configurations stored in yaml configuration files.

@ziggurad
Copy link

Hi,

I have a similar problem and despite reading the documentation I don't know how to solve it.

Locally everything works fine. In the production environment I can't delete or edit (save) the configuration.

What should the configuration be to be able to edit the endpoint on prod?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants