Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Mutations to tables in Bricks #875

Merged
merged 4 commits into from
Aug 22, 2024
Merged

[Bug] Mutations to tables in Bricks #875

merged 4 commits into from
Aug 22, 2024

Conversation

mcop1
Copy link
Contributor

@mcop1 mcop1 commented Aug 20, 2024 •
edited
Loading

Resolves #863

@mcop1 mcop1 added the Bug label Aug 20, 2024
@mcop1 mcop1 added this to the 1.7.3 milestone Aug 20, 2024
@mcop1 mcop1 linked an issue Aug 20, 2024 that may be closed by this pull request
[Bug, EC]: Mutations to tables don't work at all #863
Closed
@mcop1 mcop1 changed the title [Bug] [Bug] Mutations to tables in Bricks Aug 20, 2024
@mcop1 mcop1 self-assigned this Aug 21, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 21, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
2 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mcop1 mcop1 marked this pull request as ready for review August 21, 2024 09:49
@mcop1
Copy link
Contributor Author

mcop1 commented Aug 21, 2024

Hello @khenow1978 ,
I created this pull request after my attention was brought to your post in the data hub discussion. Could you please check if the changes in this pull request solve your problem?

@khenow1978
Copy link

Hi.. I'm afraid I'm not a programmer and therefore I can't check the code. As soon as it has been released I can check it in the frontend but I can't really check it by looking at the code..

@mcop1
Copy link
Contributor Author

mcop1 commented Aug 22, 2024

Got it, no worries, we test it internally anyways and release it as a bugfix as soon as possible. Just wanted to have another pair of eyes on it :)

@mcop1 mcop1 merged commit d79d72d into 1.7 Aug 22, 2024
1 check passed
@mcop1 mcop1 deleted the 863-bug-ec-mutations-to-tables-dont-work-at-all branch August 22, 2024 09:36
@blankse
Copy link
Contributor

blankse commented Sep 26, 2024

@mcop1 These changes have caused regressions. As a result, our schemas with block fields in object bricks no longer work.

blankse added a commit to blankse/data-hub that referenced this pull request Sep 26, 2024
@blankse
Fix regression from pimcore#875
d0d6f70
@blankse blankse mentioned this pull request Sep 26, 2024
Merged
mcop1 pushed a commit that referenced this pull request Sep 26, 2024
@blankse
Fix regression from #875 (#890)
6a39a58
blankse added a commit to blankse/data-hub that referenced this pull request Nov 6, 2024
@blankse
Fix regression from pimcore#875
c6abe16
@blankse blankse mentioned this pull request Nov 6, 2024
Merged
mcop1 pushed a commit that referenced this pull request Nov 7, 2024
@blankse
Fix regression from #875 (#910)
f627051 
* Fix regression from #875

* getValueForObject/getValueFromObjectBrick returns mixed

* setValue return mixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mcop1 mcop1

Labels
Bug
Projects
None yet
Milestone
1.7.3
Development

Successfully merging this pull request may close these issues.

[Bug, EC]: Mutations to tables don't work at all
3 participants
@mcop1 @khenow1978 @blankse