Conflict with twig/twig ^3.9.0

[fashxp]

see also twigphp/Twig#4026 (comment)

[jdreesen]

Why do you add the conflict here and not on pimcore/pimcore? That's the repo requiring rybakit/twig-deferred-extension which is incompatible.

[jdreesen]

pimcore/pimcore#16958

[fashxp]

@jdreesen At least up to now, I was thinking, if one doesn't use deferred blocks in the project, they still would be able to use the latest twig version?
We are still thinking of how we can tackle this in a generic way, and also waiting for a response form the rybakit guys.
So this is the quick solution, also to fix our demo. But in the end, the final solution has to be in pimcore/pimcore indeed.
Thx for the PR!

[jdreesen]

I don't understand. Why does pimcore/pimcore then require rybakit/twig-deferred-extension if it doesn't use it?

[fashxp]

I don't understand. Why does pimcore/pimcore then require rybakit/twig-deferred-extension if it doesn't use it?

a valid point, we need to check.

[blankse]

Comes from pimcore/pimcore@7591812. At that time the demo templates were in the pimcore/pimcore project. I think we can remove phive/twig-extensions-deferred from the core and only make it required here in the demo.

[kingjia90]

FYI Merging and tagging this for "hotfixing" purposes. We will definitely look into removing it from the core, but in there it is more "bureaucratic" (and taking longer time) to be officially removing it (you know, maybe a minor release,changelog,deprecations,bc-breaks etc..)

[blankse]

@kingjia90 I created a PR to remve it from core:
pimcore/pimcore#16966

I also created PRs to add it here to demo and also to customer-data-framework and ecommerce-framework because there are also deferred twig blocks. There I also added the conflict to twig ^3.9.0:

• Add rybakit/twig-deferred-extension to composer.json #576
• Add rybakit/twig-deferred-extension to composer.json customer-data-framework#531
• Add rybakit/twig-deferred-extension to composer.json ecommerce-framework-bundle#179