Bugfix(PricingRules): Prevent Error when adding a new Pricing Rule with a name that exists #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
recheck |
jdreesen
reviewed
Nov 19, 2024
src/PricingManager/Rule/Dao.php
Outdated
Comment on lines
79
to
85
| $this->db->beginTransaction(); | ||
| if (!$this->model->getId()) { | ||
| $this->create(); | ||
| } | ||
|
|
||
| $this->update(); | ||
| $this->db->commit(); |
There was a problem hiding this comment.
Shouldn't we also rollback on error?
There was a problem hiding this comment.
Yes sure - added the rollback
mattamon
reviewed
Nov 22, 2024
| $this->update(); | ||
| $this->update(); | ||
| $this->db->commit(); | ||
| } catch (\Exception $e) { |
There was a problem hiding this comment.
Can you please import the Exception instead of using the global namespace?
There was a problem hiding this comment.
Hmm... but it is like this everywhere in the bundle, so I would keep it like this.
If you want it differently - feel free to change it, but I would then suggest to also change it in the other places to be consistent.
BR
There was a problem hiding this comment.
I know, but improving bit by bit also works :)
In other bundles we already have CS Fixer Rules in place, but it's only a small change so I will do it quickly :)
mattamon
requested changes
Nov 22, 2024
…tal (#200) * Set amount to the subtotal when the discount amount exceeds the subtotal * Make not discounting price modifications optional * Remove deprecation
* [WIP] Initial opensearch draft * Apply php-cs-fixer changes * Indexing works with opensearch * add small cleanup * add small cleanup * Check productlisting with opensearch tenant * Apply php-cs-fixer changes * Replace elastic search everywhere * add more cleanup * add more cleanup * add more cleanup * add original sync command * remove debug * Apply php-cs-fixer changes * Add deprecations and duplicate filtertypes for opensearch * Apply php-cs-fixer changes * Add docs for OpenSearch * Apply php-cs-fixer changes * Add to ignore 404 on create-index * Apply php-cs-fixer changes * fix: ignore 404 as we handle it differently * fix: ignore 404 as we handle it differently * Prepare groups for multi select --------- Co-authored-by: mattamon <[email protected]> Co-authored-by: lukmzig <[email protected]> Co-authored-by: lukmzig <[email protected]>
…th a name that exists When you create a Pricing Rule with an name that already exists the backend interface is not loading the pricing rules anymore because it inserts a row with "null" values. The reason is because the create() call is successfully but at the update() call you get an errror because a pricing Rule with that name already exists. Solution -> wrap it into a transaction
ctippler
force-pushed
the
bugfix-pricing-rule
branch
from
f57131c to
7bda5e2
Compare
…tal (#200) * Set amount to the subtotal when the discount amount exceeds the subtotal * Make not discounting price modifications optional * Remove deprecation
* [WIP] Initial opensearch draft * Apply php-cs-fixer changes * Indexing works with opensearch * add small cleanup * add small cleanup * Check productlisting with opensearch tenant * Apply php-cs-fixer changes * Replace elastic search everywhere * add more cleanup * add more cleanup * add more cleanup * add original sync command * remove debug * Apply php-cs-fixer changes * Add deprecations and duplicate filtertypes for opensearch * Apply php-cs-fixer changes * Add docs for OpenSearch * Apply php-cs-fixer changes * Add to ignore 404 on create-index * Apply php-cs-fixer changes * fix: ignore 404 as we handle it differently * fix: ignore 404 as we handle it differently * Prepare groups for multi select --------- Co-authored-by: mattamon <[email protected]> Co-authored-by: lukmzig <[email protected]> Co-authored-by: lukmzig <[email protected]>
…th a name that exists When you create a Pricing Rule with an name that already exists the backend interface is not loading the pricing rules anymore because it inserts a row with "null" values. The reason is because the create() call is successfully but at the update() call you get an errror because a pricing Rule with that name already exists. Solution -> wrap it into a transaction
…th a name that exists When you create a Pricing Rule with an name that already exists the backend interface is not loading the pricing rules anymore because it inserts a row with "null" values. The reason is because the create() call is successfully but at the update() call you get an errror because a pricing Rule with that name already exists. Solution -> wrap it into a transaction
ctippler
added a commit
to ctippler/ecommerce-framework-bundle
that referenced
this pull request
Nov 22, 2024
|
I shomehow destroyed my fork with trying to rebase this. |
ctippler
added a commit
to ctippler/ecommerce-framework-bundle
that referenced
this pull request
Nov 25, 2024
This reverts commit 8806162.
mattamon
pushed a commit
that referenced
this pull request
Nov 29, 2024
…th a name that exists (#216) * Bugfix Pricing Rules -> #214 * Revert "Bugfix Pricing Rules -> #214" This reverts commit 8806162. * fix copy paste error * Update src/PricingManager/Rule/Dao.php Co-authored-by: Jacob Dreesen <[email protected]> --------- Co-authored-by: Jacob Dreesen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you create a Pricing Rule with an name that already exists in the backend, a invalid Database entry is added. Therefore the admin interface is not loading the pricing rules anymore.
The reason is because the create() call is successfully but in the update() call you get an error because a pricing Rule with that name already exists. Solution -> wrap it into a transaction so both queries have to be executed successfully