Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Request::get with explicit input sources #14138

Open
22 of 24 tasks
dvesh3 opened this issue Jan 25, 2023 · 3 comments · Fixed by #17873
Open
22 of 24 tasks

Replace Request::get with explicit input sources #14138

dvesh3 opened this issue Jan 25, 2023 · 3 comments · Fixed by #17873
Assignees

Comments

@dvesh3
Copy link
Contributor

dvesh3 commented Jan 25, 2023

Improvement description

In Symfony 5.4, Request::get() was marked as internal and we should switch to $request->attributes->get() or $request->query->get() calls.

see more details https://symfony.com/blog/new-in-symfony-5-4-controller-changes

Tasks

Preview Give feedback
  1. Pimcore:ToDo Task
    kingjia90
  2. Pimcore:ToDo Task
    robertSt7
  3. Pimcore:ToDo Task
    kingjia90
  4. Pimcore:ToDo Task
  5. Pimcore:ToDo Task
    mcop1
  6. Pimcore:ToDo Task
    kingjia90
  7. Improvement Pimcore:ToDo Task
    kingjia90
  8. Pimcore:Backlog
    kingjia90
  9. Pimcore:Backlog
    kingjia90 mattamon
  10. Pimcore:Backlog
  11. Pimcore:Backlog Task
    kingjia90 mattamon
  12. Improvement Pimcore:ToDo
    kingjia90
  13. Improvement Pimcore:Priority
    kingjia90
@brusch
Copy link
Member

brusch commented Jan 27, 2023

Partly resolved by #13981

@jdreesen
Copy link
Contributor

jdreesen commented Dec 2, 2024

Was it intentional to close this?

@kingjia90 kingjia90 reopened this Dec 2, 2024
@kingjia90
Copy link
Contributor

@jdreesen ops no, as this is more a collecting list and it's not fully completed yet. Thank you for the heads-up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants