From 280942df798c026dc12e4b08cf8abf721885b174 Mon Sep 17 00:00:00 2001 From: Ran Date: Thu, 25 Jan 2024 11:32:51 +0800 Subject: [PATCH] Apply suggestions from code review Co-authored-by: xixirangrang --- en/deploy-tiproxy.md | 4 ++-- zh/deploy-tiproxy.md | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/en/deploy-tiproxy.md b/en/deploy-tiproxy.md index 200a930a5..01610880b 100644 --- a/en/deploy-tiproxy.md +++ b/en/deploy-tiproxy.md @@ -48,7 +48,7 @@ If you need to deploy TiProxy for an existing TiDB cluster, follow these steps: 4. Configure the related parameters in `spec.tidb` of the TidbCluster CR. For example: - + It is recommended to configure `graceful-wait-before-shutdown` to a value longer than the maximum duration of the transactions in your application. This is used together with TiProxy's connection migration feature. For more information, see [TiProxy Limitations](https://docs.pingcap.com/tidb/v7.6/tiproxy-overview#limitations). + + It is recommended to configure `graceful-wait-before-shutdown` to a value greater than the maximum duration of the transactions in your application. This is used together with TiProxy's connection migration feature. For more information, see [TiProxy Limitations](https://docs.pingcap.com/tidb/v7.6/tiproxy-overview#limitations). ```yaml spec: @@ -74,7 +74,7 @@ If you need to deploy TiProxy for an existing TiDB cluster, follow these steps: session-token-signing-key = "/var/session/tls.key" ``` - For more information, refer to TiDB configuration file [`session-token-signing-cert`](https://docs.pingcap.com/tidb/stable/tidb-configuration-file#session-token-signing-cert-new-in-v640). + For more information, see [`session-token-signing-cert`](https://docs.pingcap.com/tidb/stable/tidb-configuration-file#session-token-signing-cert-new-in-v640). After TiProxy is started, you can find the corresponding `tiproxy-sql` load balancer service by running the following command. diff --git a/zh/deploy-tiproxy.md b/zh/deploy-tiproxy.md index 8162ca9a5..515e0c1d1 100644 --- a/zh/deploy-tiproxy.md +++ b/zh/deploy-tiproxy.md @@ -48,7 +48,7 @@ summary: 了解如何在 Kubernetes 上为已有 TiDB 集群部署负载均衡 T 4. 配置 TidbCluster CR 中 `spec.tidb` 的相关参数： - + 推荐设置 TiDB 的 `graceful-wait-before-shutdown` 大于应用程序最长的事务的持续时间，配合 TiProxy 的连接迁移，详见 [TiProxy 使用限制](https://docs.pingcap.com/zh/tidb/v7.6/tiproxy-overview#使用限制)。 + + 推荐设置 TiDB `graceful-wait-before-shutdown` 的值大于应用程序中事务的最长的持续时间，配合 TiProxy 的连接迁移。详见 [TiProxy 使用限制](https://docs.pingcap.com/zh/tidb/v7.6/tiproxy-overview#使用限制)。 ```yaml spec: @@ -74,7 +74,7 @@ summary: 了解如何在 Kubernetes 上为已有 TiDB 集群部署负载均衡 T session-token-signing-key = "/var/session/tls.key" ``` - 详见 TiDB 配置文档 [`session-token-signing-key`](https://docs.pingcap.com/zh/tidb/v7.6/tidb-configuration-file#session-token-signing-cert-从-v640-版本开始引入)。 + 详见 [`session-token-signing-key`](https://docs.pingcap.com/zh/tidb/v7.6/tidb-configuration-file#session-token-signing-cert-从-v640-版本开始引入)。 TiProxy 启动后，可通过以下命令找到对应的 `tiproxy-sql` 负载均衡服务。