From 33737e9899faee007285718c426a3d10266d6792 Mon Sep 17 00:00:00 2001 From: Ran Date: Thu, 11 Jan 2024 14:25:43 +0800 Subject: [PATCH] Apply suggestions from code review Co-authored-by: xixirangrang --- en/deploy-tiproxy.md | 2 +- en/enable-tls-between-components.md | 2 +- en/scale-a-tidb-cluster.md | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/en/deploy-tiproxy.md b/en/deploy-tiproxy.md index ed4991796..71b600840 100644 --- a/en/deploy-tiproxy.md +++ b/en/deploy-tiproxy.md @@ -17,7 +17,7 @@ If you need to deploy TiProxy for an existing TiDB cluster, follow these steps: > **Note:** > -> If your server does not have access to the Internet, refer to [Deploy a TiDB Cluster](deploy-on-general-kubernetes.md#deploy-the-tidb-cluster) to download the `pingcap/tiproxy` Docker image to a machine with access to the Internet and then upload the Docker image to your server. Then, use `docker load` to install the Docker image on your server. +> If your server does not have access to the internet, refer to [Deploy a TiDB Cluster](deploy-on-general-kubernetes.md#deploy-the-tidb-cluster) to download the `pingcap/tiproxy` Docker image to a machine with access to the internet and then upload the Docker image to your server. Then, use `docker load` to install the Docker image on your server. 1. Edit the TidbCluster Custom Resource (CR): diff --git a/en/enable-tls-between-components.md b/en/enable-tls-between-components.md index b12088c17..b19ca7430 100644 --- a/en/enable-tls-between-components.md +++ b/en/enable-tls-between-components.md @@ -414,7 +414,7 @@ This section describes how to issue certificates using two methods: `cfssl` and cfssl print-defaults csr > tiproxy-server.json ``` - 2. Edit this file to change the `CN`, `hosts` attributes: + 2. Edit this file to change the `CN` and `hosts` attributes: ```json ... diff --git a/en/scale-a-tidb-cluster.md b/en/scale-a-tidb-cluster.md index 93c755342..6ed6febe8 100644 --- a/en/scale-a-tidb-cluster.md +++ b/en/scale-a-tidb-cluster.md @@ -18,7 +18,7 @@ Horizontally scaling TiDB means that you scale TiDB out or in by adding or remov ### Horizontally scale PD, TiKV, TiDB, and TiProxy -To scale PD, TiKV, TiDB, or TiProxy horizontally, use kubectl to modify `spec.pd.replicas`, `spec.tikv.replicas`, `spec.tidb.replicas`, and `spec.tiproxy.replicas` in the `TidbCluster` object of the cluster to a desired value. +To scale PD, TiKV, TiDB, or TiProxy horizontally, use kubectl to modify `spec.pd.replicas`, `spec.tikv.replicas`, `spec.tidb.replicas`, and `spec.tiproxy.replicas` in the `TidbCluster` object of the cluster to desired values. 1. Modify the `replicas` value of a component as needed. For example, configure the `replicas` value of PD to 3: @@ -167,7 +167,7 @@ Vertically scaling TiDB means that you scale TiDB up or down by increasing or de This section describes how to vertically scale up or scale down components including PD, TiKV, TiDB, TiProxy, TiFlash, and TiCDC. -- To scale up or scale down PD, TiKV, TiDB, and TiProxy, use kubectl to modify `spec.pd.resources`, `spec.tikv.resources`, and `spec.tidb.resources` in the `TidbCluster` object that corresponds to the cluster to a desired value. +- To scale up or scale down PD, TiKV, TiDB, and TiProxy, use kubectl to modify `spec.pd.resources`, `spec.tikv.resources`, and `spec.tidb.resources` in the `TidbCluster` object that corresponds to the cluster to desired values. - To scale up or scale down TiFlash, modify the value of `spec.tiflash.resources`.