Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiDB 7.1+ checkpoint restore requires s3:DeleteObject permission #17111

Merged
merged 4 commits into from
Apr 11, 2024
Merged

TiDB 7.1+ checkpoint restore requires s3:DeleteObject permission #17111

merged 4 commits into from
Apr 11, 2024

Conversation

yahonda
Copy link
Member

@yahonda yahonda commented Apr 10, 2024 •
edited by hfxsd
Loading

What is changed, added or deleted? (Required)

This pull request adds s3:DeleteObject permission because TiDB 7.1+ checkpoint restore requires it.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

Fix #16961

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@yahonda yahonda mentioned this pull request Apr 10, 2024
Closed
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 10, 2024
@hfxsd hfxsd self-assigned this Apr 11, 2024
@hfxsd hfxsd added translation/doing This PR's assignee is translating this PR. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.4 needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed missing-translation-status This PR does not have translation status info. labels Apr 11, 2024
@hfxsd hfxsd added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Apr 11, 2024
@hfxsd hfxsd mentioned this pull request Apr 11, 2024
Merged
18 tasks
@hfxsd hfxsd added type/bugfix This PR fixes a bug. area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 11, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 11, 2024

@Leavrth: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 11, 2024
@hfxsd hfxsd requested a review from Oreoxmt April 11, 2024 08:35
Oreoxmt
Oreoxmt approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the approved label Apr 11, 2024
@ti-chi-bot ti-chi-bot bot merged commit b36bdd2 into pingcap:master Apr 11, 2024
9 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 11, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #17157.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #17158.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 11, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17159.

This was referenced Apr 11, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #17160.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Apr 11, 2024
@yahonda @ti-chi-bot
This is an automated cherry-pick of pingcap#17111
28887bc 
Signed-off-by: ti-chi-bot <[email protected]>
This was referenced Apr 11, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #17161.

This was referenced Apr 11, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #17162.

This was referenced Apr 11, 2024
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Apr 11, 2024
@ti-chi-bot
TiDB 7.1+ checkpoint restore requires s3:DeleteObject permission (#…
2e280a9 
…17111) (#17157)
ti-chi-bot bot pushed a commit that referenced this pull request Apr 11, 2024
@ti-chi-bot
TiDB 7.1+ checkpoint restore requires s3:DeleteObject permission (#…
8a761d7 
…17111) (#17158)
This was referenced Apr 11, 2024
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Apr 11, 2024
@ti-chi-bot
TiDB 7.1+ checkpoint restore requires s3:DeleteObject permission (#…
5ca9129 
…17111) (#17159)
ti-chi-bot bot pushed a commit that referenced this pull request Apr 11, 2024
@ti-chi-bot
TiDB 7.1+ checkpoint restore requires s3:DeleteObject permission (#…
f54096d 
…17111) (#17162)
ti-chi-bot bot pushed a commit that referenced this pull request Apr 11, 2024
@ti-chi-bot
TiDB 7.1+ checkpoint restore requires s3:DeleteObject permission (#…
1fd212d 
…17111) (#17161)
ti-chi-bot bot pushed a commit that referenced this pull request Apr 11, 2024
@ti-chi-bot
TiDB 7.1+ checkpoint restore requires s3:DeleteObject permission (#…
99f5684 
…17111) (#17160)
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 11, 2024
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Apr 11, 2024
@ti-chi-bot
TiDB 7.1+ checkpoint restore requires s3:DeleteObject permission (#…
2e2db38 
…17111) (#17159) (#17164)
dveeden pushed a commit to dveeden/docs that referenced this pull request May 15, 2024
@yahonda @dveeden
TiDB 7.1+ checkpoint restore requires s3:DeleteObject permission (p…
dcf45d4 
…ingcap#17111)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@Leavrth Leavrth Leavrth approved these changes

@hfxsd hfxsd hfxsd approved these changes

Assignees

@hfxsd hfxsd

Labels
approved area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does "Checkpoint Restore" needs s3:DeleteObject or equivalent permissions?
5 participants
@yahonda @hfxsd @ti-chi-bot @Leavrth @Oreoxmt