Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup: add kvcdc server topylogy example #19230

Merged
merged 19 commits into from
Nov 6, 2024
Merged

tiup: add kvcdc server topylogy example #19230

merged 19 commits into from
Nov 6, 2024

Conversation

wk989898
Copy link
Contributor

@wk989898 wk989898 commented Oct 29, 2024 •
edited by qiancai
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

topology config supports TiCDC server and TiKV-CDC, they are different.
https://asktug.com/t/topic/1034131

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 29, 2024

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai qiancai self-assigned this Oct 29, 2024
@qiancai qiancai added type/enhancement The issue or PR belongs to an enhancement. ONCALL Relates to documentation oncall. area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. labels Oct 29, 2024
qiancai
qiancai reviewed Oct 29, 2024
View reviewed changes
tiup/tiup-cluster-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-topology-reference.md Outdated Show resolved Hide resolved
wk989898 and others added 10 commits October 29, 2024 16:56
@wk989898 @qiancai
Update tiup/tiup-cluster-topology-reference.md
b4f5a6b 
Co-authored-by: Grace Cai <[email protected]>
@wk989898 @qiancai
Update tiup/tiup-cluster-topology-reference.md
3768e54 
Co-authored-by: Grace Cai <[email protected]>
@wk989898 @qiancai
Update tiup/tiup-cluster-topology-reference.md
e03caaa 
Co-authored-by: Grace Cai <[email protected]>
@wk989898 @qiancai
Update tiup/tiup-cluster-topology-reference.md
eb4fffb 
Co-authored-by: Grace Cai <[email protected]>
@wk989898 @qiancai
Update tiup/tiup-cluster-topology-reference.md
13ba4f8 
Co-authored-by: Grace Cai <[email protected]>
@wk989898 @qiancai
Update tiup/tiup-cluster-topology-reference.md
555c97a 
Co-authored-by: Grace Cai <[email protected]>
@wk989898 @qiancai
Update tiup/tiup-cluster-topology-reference.md
1e332ff 
Co-authored-by: Grace Cai <[email protected]>
@wk989898 @qiancai
Update tiup/tiup-cluster-topology-reference.md
11130d3 
Co-authored-by: Grace Cai <[email protected]>
@wk989898 @qiancai
Update tiup/tiup-cluster-topology-reference.md
fd14ffc 
Co-authored-by: Grace Cai <[email protected]>
@qiancai
Update tiup-cluster-topology-reference.md
8c25483
@qiancai qiancai added needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. and removed missing-translation-status This PR does not have translation status info. labels Oct 29, 2024
@qiancai qiancai mentioned this pull request Oct 29, 2024
Merged
16 tasks
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 29, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 5, 2024

@xhebox: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 6, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-29 09:20:43.804387424 +0000 UTC m=+341556.643542962: ☑️ agreed by qiancai.
  • 2024-11-06 03:12:44.477401558 +0000 UTC m=+1010677.316557101: ☑️ agreed by hfxsd.

qiancai
qiancai approved these changes Nov 6, 2024
View reviewed changes
tiup/tiup-cluster-topology-reference.md Outdated Show resolved Hide resolved
@qiancai
Copy link
Collaborator

qiancai commented Nov 6, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 6, 2024
@ti-chi-bot ti-chi-bot bot merged commit 683915e into pingcap:master Nov 6, 2024
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #19343.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 6, 2024
@wk989898 @ti-chi-bot
This is an automated cherry-pick of pingcap#19230
588369f 
Signed-off-by: ti-chi-bot <[email protected]>
This was referenced Nov 6, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #19344.

This was referenced Nov 6, 2024
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Nov 6, 2024
@ti-chi-bot
tiup: add kvcdc server topylogy example (#19230) (#19343)
6fbb3de
ti-chi-bot bot pushed a commit that referenced this pull request Nov 6, 2024
@ti-chi-bot
tiup: add kvcdc server topylogy example (#19230) (#19344)
c9fc783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@hfxsd hfxsd hfxsd approved these changes

@xhebox xhebox xhebox approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

Assignees

@qiancai qiancai

Labels
approved area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. ONCALL Relates to documentation oncall. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wk989898 @qiancai @ti-chi-bot @flowbehappy @xhebox @hfxsd