From ac572682db042d378b8b51ecd2be350c3c514758 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20van=20Eeden?= Date: Fri, 8 Dec 2023 12:31:47 +0100 Subject: [PATCH] checker(dm): Replace URL in error (#10211) close pingcap/tiflow#10210 --- dm/pkg/checker/binlog.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dm/pkg/checker/binlog.go b/dm/pkg/checker/binlog.go index 7a9e7f8f416..4e725ba0ca4 100644 --- a/dm/pkg/checker/binlog.go +++ b/dm/pkg/checker/binlog.go @@ -105,7 +105,7 @@ func (pc *MySQLBinlogFormatChecker) Check(ctx context.Context) *Result { } if strings.ToUpper(value) != "ROW" { result.Errors = append(result.Errors, NewError("binlog_format is %s, and should be ROW", value)) - result.Instruction = "MySQL as source: please execute 'set global binlog_format=ROW;'; AWS Aurora (MySQL)/RDS MySQL as source: please refer to the document to create a new DB parameter group and set the binlog_format=row: https://docs.aws.amazon.com/zh_cn/AmazonRDS/latest/AuroraUserGuide/USER_WorkingWithDBInstanceParamGroups.html. Then modify the instance to use the new DB parameter group and restart the instance to take effect." + result.Instruction = "MySQL as source: please execute 'set global binlog_format=ROW;'; AWS Aurora (MySQL)/RDS MySQL as source: please refer to the document to create a new DB parameter group and set the binlog_format=row: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/USER_WorkingWithDBInstanceParamGroups.html. Then modify the instance to use the new DB parameter group and restart the instance to take effect." return result } result.State = StateSuccess @@ -183,7 +183,7 @@ func (pc *MySQLBinlogRowImageChecker) Check(ctx context.Context) *Result { } if strings.ToUpper(value) != "FULL" { result.Errors = append(result.Errors, NewError("binlog_row_image is %s, and should be FULL", value)) - result.Instruction = "MySQL as source: please execute 'set global binlog_row_image = FULL;'; AWS Aurora (MySQL)/RDS MySQL as source: please refer to the document to create a new DB parameter group and set the binlog_row_image = FULL: https://docs.aws.amazon.com/zh_cn/AmazonRDS/latest/AuroraUserGuide/USER_WorkingWithDBInstanceParamGroups.html Then modify the instance to use the new DB parameter group and restart the instance to take effect." + result.Instruction = "MySQL as source: please execute 'set global binlog_row_image = FULL;'; AWS Aurora (MySQL)/RDS MySQL as source: please refer to the document to create a new DB parameter group and set the binlog_row_image = FULL: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/USER_WorkingWithDBInstanceParamGroups.html Then modify the instance to use the new DB parameter group and restart the instance to take effect." return result } result.State = StateSuccess