Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TiCDC openapi v2 support downstream ca cert key data not filepath #10245

Open
cchenkey opened this issue Dec 5, 2023 · 1 comment
Open

TiCDC openapi v2 support downstream ca cert key data not filepath #10245

cchenkey opened this issue Dec 5, 2023 · 1 comment
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@cchenkey
Copy link

cchenkey commented Dec 5, 2023

Is your feature request related to a problem?

No

Describe the feature you'd like

https://docs.pingcap.com/zh/tidb/stable/ticdc-sink-to-kafka

Currently, ticdc's creation of changefeed supports specifying the CA certificate paths for Kafka and MySQL to use. In practical scenarios, it may be more convenient to create changefeed by passing in certificate data, so there is no need to create certificate files on the storage disk of ticdc.

Describe alternatives you've considered

it may be more convenient to create changefeed by passing in certificate data, so there is no need to create certificate files on the storage disk of ticdc.

Teachability, Documentation, Adoption, Migration Strategy

I think a parameter for passing CA certificate data should be added to openapi v2, based current parameter.

@cchenkey cchenkey added the type/feature Issues about a new feature label Dec 5, 2023
@CharlesCheung96
Copy link
Contributor

For other sinks, it is also reasonable to pass tls configuration by parameter, since the changefeed should not be affected by the deployment behavior.

@CharlesCheung96 CharlesCheung96 added type/enhancement The issue or PR belongs to an enhancement. and removed type/feature Issues about a new feature labels Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants