Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TiCDC Redo] Redo log files don't have version control #10266

Open
zhangjinpeng87 opened this issue Dec 6, 2023 · 0 comments
Open

[TiCDC Redo] Redo log files don't have version control #10266

zhangjinpeng87 opened this issue Dec 6, 2023 · 0 comments
Assignees
@sdojjy
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@zhangjinpeng87
Copy link
Contributor

zhangjinpeng87 commented Dec 6, 2023 •
edited
Loading

What is your question?

TiCDC Redo log files don't have version control, there is no file header to describe the version of file format and the compression algorithm used. This make the redo file is hard to extend. For example #10171 introduced LZ4 compression for redo file, but it depends on the hardcode LZ4 magic number to judge if this file is compressed or not. What if this file is not compressed but the first 4 bytes are accidentally match the hardcode LZ4 magic number?
@zhangjinpeng87 zhangjinpeng87 added the question Further information is requested. label Dec 6, 2023
@zhangjinpeng87 zhangjinpeng87 added type/enhancement The issue or PR belongs to an enhancement. and removed question Further information is requested. labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdojjy sdojjy

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sdojjy @zhangjinpeng87