redo(cdc): custom redo event cache and disable it by default (#10139) #10319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#10139) close pingcap#10143 # Conflicts: # cdc/processor/sinkmanager/manager.go
ti-chi-bot
bot
added
release-note
|
|
||
| // ConsistentMemoryUsage represents memory usage of Consistent module. | ||
| type ConsistentMemoryUsage struct { | ||
| MemoryQuotaPercentage uint64 `json:"memory_quota_percentage"` |
There was a problem hiding this comment.
redo_memory_quota_percentage
There was a problem hiding this comment.
The struct is named ConsistentMemoryUsage, with the Consistent prefix. so internal fields can be shorter.
nongfushanquan
approved these changes
Dec 18, 2023
|
/retest-required |
hicqu
approved these changes
Dec 18, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hicqu, nongfushanquan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
bot
merged commit 64d0522
into
pingcap:release-6.5-20231218-v6.5.6
8 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #10143
Conflicts:
cdc/processor/sinkmanager/manager.go
What problem does this PR solve?
Issue Number: close #xxx
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note