Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kafka(ticdc): make column selector can work normally to filter out columns #9920

Merged
merged 32 commits into from
Nov 8, 2023
Merged

kafka(ticdc): make column selector can work normally to filter out columns #9920

merged 32 commits into from
Nov 8, 2023

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Oct 17, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9967

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 26, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2023
@3AceShowHand 3AceShowHand changed the title [DNM]kafka(ticdc): add column selector transformer kafka(ticdc): make column selector can work normally to filter out columns Oct 30, 2023
@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-storage-test

@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 30, 2023
@3AceShowHand
Copy link
Contributor Author

/check-issue-triage-complete

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-storage-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 7, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-06 02:29:18.689383487 +0000 UTC m=+3438556.276493631: ☑️ agreed by asddongmen.
  • 2023-11-07 01:09:14.08138126 +0000 UTC m=+3520151.668491405: ☑️ agreed by sdojjy.

@3AceShowHand
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, nongfushanquan, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/test verify

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

1 similar comment
@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

@3AceShowHand
Copy link
Contributor Author

/retest

1 similar comment
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@ti-chi-bot ti-chi-bot bot merged commit 055badf into pingcap:master Nov 8, 2023
3 checks passed
@3AceShowHand
Copy link
Contributor Author

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@3AceShowHand: new pull request created to branch release-7.5: #10060.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 9, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Nov 9, 2023
@ti-chi-bot
kafka(ticdc): make column selector can work normally to filter out co…
bb6cb52 
…lumns (#9920) (#10060)

close #9967
@zhangjinpeng87 zhangjinpeng87 mentioned this pull request Dec 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@asddongmen asddongmen asddongmen approved these changes

@sdojjy sdojjy sdojjy approved these changes

@CharlesCheung96 CharlesCheung96 Awaiting requested review from CharlesCheung96

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

column selector works normally filter out columns
5 participants
@3AceShowHand @ti-chi-bot @sdojjy @asddongmen @nongfushanquan