Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csv: delimiter supports at most 2 characters #9970

Merged
merged 6 commits into from
Dec 2, 2023
Merged

csv: delimiter supports at most 2 characters #9970

merged 6 commits into from
Dec 2, 2023

Conversation

zhangjinpeng87
Copy link
Contributor

@zhangjinpeng87 zhangjinpeng87 commented Oct 30, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9969

What is changed and how it works?

CSV delimiter supports at most 2 characters and to support hex delimiters like "FE" or "FF"

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

Yes, TODO

Release note 

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

TiCDC sink to CSV customized delimiter supports at most 2 characters.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Oct 30, 2023
@zhangjinpeng87
test: fix output string
e8dcfe8 
Signed-off-by: zhangjinpeng1987 <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 31, 2023
CharlesCheung96
CharlesCheung96 reviewed Oct 31, 2023
View reviewed changes
pkg/config/sink_test.go Outdated
{
name: "delimiter and quote contain common characters",
config: &CSVConfig{
Quote: "EX",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quote is limited to one character.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, fixed

@zhangjinpeng87
test: fix quote output
56a6e54 
Signed-off-by: zhangjinpeng1987 <[email protected]>
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 2, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, nongfushanquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 2, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 2, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-31 16:55:23.71264522 +0000 UTC m=+2972121.299755365: ☑️ agreed by CharlesCheung96.
  • 2023-11-02 01:41:08.205917274 +0000 UTC m=+3090065.793027419: ☑️ agreed by nongfushanquan.

@zhangjinpeng87
Copy link
Contributor Author

/retest

2 similar comments
@zhangjinpeng87
Copy link
Contributor Author

/retest

@hicqu
Copy link
Contributor

hicqu commented Nov 16, 2023

/retest

@zhangjinpeng87
merge master
ffc2857 
Signed-off-by: zhangjinpeng1987 <[email protected]>
@zhangjinpeng87
fix error message not match
3099f81 
Signed-off-by: zhangjinpeng1987 <[email protected]>
@zhangjinpeng87
Copy link
Contributor Author

/test cdc-integration-mysql-test

@zhangjinpeng87
Copy link
Contributor Author

/test cdc-integration-storage-test

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 1, 2023

@zhangjinpeng1987: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test cdc-integration-kafka-test
  • /test cdc-integration-mysql-test
  • /test cdc-integration-pulsar-test
  • /test cdc-integration-storage-test
  • /test dm-compatibility-test
  • /test dm-integration-test
  • /test engine-integration-test
  • /test verify
  • /test wip-pull-build
  • /test wip-pull-check
  • /test wip-pull-unit-test-cdc
  • /test wip-pull-unit-test-dm
  • /test wip-pull-unit-test-engine

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tiflow/ghpr_verify
  • pingcap/tiflow/pull_cdc_integration_kafka_test
  • pingcap/tiflow/pull_cdc_integration_storage_test
  • pingcap/tiflow/pull_cdc_integration_test
  • pingcap/tiflow/pull_dm_compatibility_test
  • pingcap/tiflow/pull_dm_integration_test
  • pingcap/tiflow/pull_engine_integration_test

In response to this:

/test cdc-integration-storage-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhangjinpeng87
Copy link
Contributor Author

/test cdc-integration-mysql-test

@ti-chi-bot ti-chi-bot bot merged commit 5480006 into pingcap:master Dec 2, 2023
14 checks passed
@zhangjinpeng87 zhangjinpeng87 deleted the relief-csv-delimiter-limitation branch December 2, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@nongfushanquan nongfushanquan nongfushanquan approved these changes

Assignees
No one assigned
Labels
approved first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature-request] sink to cloud storage: customized delimiter with 2 characters
4 participants
@zhangjinpeng87 @hicqu @CharlesCheung96 @nongfushanquan