Merge pull request #721 from pinkary-project/fix/link-preview-tests-r…

…elated-errors Fix/link preview tests related errors
pinkary-project · Nov 2, 2024 · bc02a32 · bc02a32
2 parents 5df17b8 + 561cfc2
commit bc02a32
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/app/Services/MetaData.php b/app/Services/MetaData.php
@@ -52,7 +52,7 @@ private function getData(): Collection
 
             if ($response->ok()) {
                 $data = $this->parse($response->body())
-                    ->filter(fn ($value): bool => $value !== '');
+                    ->filter(fn (string $value): bool => $value !== '');
             }
         } catch (ConnectionException) {
             // Catch but not capture the exception
@@ -77,8 +77,10 @@ private function fetchOEmbed(string $service, array $options): Collection
             );
 
             if ($response->ok()) {
-                $data = collect((array) $response->json())
-                    ->filter(fn ($value): bool => $value !== '');
+                /** @var Collection<string, string|null> $data */
+                $data = $response->collect();
+                $data = $data
+                    ->filter(fn (?string $value): bool => (string) $value !== '');
             }
         } catch (ConnectionException) {
             // Catch but not capture the exception
@@ -116,9 +118,9 @@ private function parse(string $content): Collection
                 }
 
                 collect(['name', 'property'])
-                    ->map(fn ($name): string => $meta->getAttribute($name))
-                    ->filter(fn ($attribute): bool => in_array(explode(':', $attribute)[0], $interested_in))
-                    ->each(function ($attribute) use ($data, $allowed, $meta): void {
+                    ->map(fn (string $name): string => $meta->getAttribute($name))
+                    ->filter(fn (string $attribute): bool => in_array(explode(':', $attribute)[0], $interested_in))
+                    ->each(function (string $attribute) use ($data, $allowed, $meta): void {
                         $key = explode(':', $attribute)[1];
                         if (! $data->has($key) && in_array($key, $allowed, true)) {
                             $data->put($key, $meta->getAttribute('content'));

diff --git a/tests/.pest/snapshots/Unit/Services/ContentTest/it_ignores_mention_inside__a_.snap b/tests/.pest/snapshots/Unit/Services/ContentTest/it_ignores_mention_inside__a_.snap
@@ -25,5 +25,4 @@
             <a href="https://pinkary.com/@nunomaduro" target="_blank" rel="noopener noreferrer"
                class="text-xs text-slate-500 group-hover/preview:text-pink-600">From: pinkary.com</a>
         </div>
-
 </div>
diff --git a/...napshots/Unit/Services/ContentTest/only_links_with_images_or_html_oEmbeds_are_parsed.snap b/...napshots/Unit/Services/ContentTest/only_links_with_images_or_html_oEmbeds_are_parsed.snap
@@ -25,5 +25,4 @@ Sure, here is the link: <div
             <a href="https://laravel.com" target="_blank" rel="noopener noreferrer"
                class="text-xs text-slate-500 group-hover/preview:text-pink-600">From: laravel.com</a>
         </div>
-
 </div>. Let me know if you have any questions.