Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow opType to be passed to cli #193

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

johan-liljegren-visma
Copy link
Contributor

Make it possible to pass --opType to the cli.

@mcollina
Copy link
Member

mcollina commented Sep 3, 2024

Thanks for opening a PR! Can you please add a unit test to https://github.com/pinojs/pino-elasticsearch/blob/master/test/cli.test.js?

@johan-liljegren-visma
Copy link
Contributor Author

I've added a test checking that the param is passed to the client, is this enough?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 89f4f6a into pinojs:master Oct 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants