Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTX streams leaks routines when no interceptors are registered or using custom buffers #2952

Open
OrlandoCo opened this issue Nov 15, 2024 · 0 comments

Comments

@OrlandoCo
Copy link
Contributor

OrlandoCo commented Nov 15, 2024

Your environment.

  • Version: Latest
  • Browser: Any

What did you do?

If you are using RTX streams without interceptors or with custom buffers, the RTP receiver spawns a go routine that will loop forever:
https://github.com/pion/webrtc/blob/2fd3640fa3e394aa65cd22447349bdad76c26844/rtpreceiver.go#L438C1-L490C5

What did you expect?

Interceptors related code should check for interceptor usage before spawning go routines.

What happened?

Go routines are spawned for each receiver with RTX stream causing memory leaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant