ci(linux): small coverage fixes #1188
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1188 +/- ##
==========================================
- Coverage 78.09% 0 -78.10%
==========================================
Files 53 0 -53
Lines 7077 0 -7077
==========================================
- Hits 5527 0 -5527
+ Misses 1550 0 -1550 ☔ View full report in Codecov by Sentry. |
|
...and this doesn't actually fix the coverage step on Debian Testing, lcov 2.0 is creating more issues than expected. I'll try to see if we can ditch it and directly use gcov instead. |
sqop is an implementation of the Stateless OpenPGP Command Line Interface, a draft RFC which describes a simple and interoperable OpenPGP CLI which works really well for automated scripts. Due to recent events in the OpenPGP ecosystem, historical users of OpenPGP and GnuPG started an effort to migrate to sop, this "new" interoperable interface. If you're interested, have a look at <https://lists.debian.org/debian-devel/2024/01/msg00026.html>. Using sop makes the Coverage step a bit faster, since there's no need to use the full GnuPG suite, designed for interactive use. You can learn more about the RFC here: <https://datatracker.ietf.org/doc/draft-dkg-openpgp-stateless-cli/>.
Tachi107
force-pushed
the
tachi-ci-linux-fixes
branch
3 times, most recently
from
d87f4e9
to
1866abc
Compare
I haven't been able to make lcov 2.0 work for us, so let's just drop it and directly use gcov instead, since codecov supports it as well.
Tachi107
force-pushed
the
tachi-ci-linux-fixes
branch
from
51a49a6
to
86bcf34
Compare
Tachi107
force-pushed
the
tachi-ci-linux-fixes
branch
from
dc6651f
to
86bcf34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finally fixes the CI Coverage step on Debian Testing, and also switches from gpgv to a sop implementation. See the individual commit messages for details :)