Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xfce processes are terminated for on-demand dekstop sessions #92

Closed
djperrefort opened this issue Oct 24, 2023 · 0 comments · Fixed by #95
Closed

Xfce processes are terminated for on-demand dekstop sessions #92

djperrefort opened this issue Oct 24, 2023 · 0 comments · Fixed by #95
Assignees

Comments

@djperrefort
Copy link
Member

When spawning desktop sessions via on-demand, Xfce launches a number of processes that are immediacy adopted by the init process. By default, shinigami terminates these processes and interrupts the user session.

We want to protect Xfce sessions from termination. A possible solution is to never terminate processes trees where any process in the tree has theXDG_SESSION_ID variable defined. In theory, this should protect any processes tied to a desktop session. The (acceptable) tradeoff is that shinigami may leave a few processes behind that would otherwise be cleaned up. Fortunately, we expect these processes to be low utilization.

Credit to @buttermutter and @iamtroy412 for the proposed solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant