Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with package: cmake #440

Open
3 of 6 tasks
henryiii opened this issue Apr 5, 2024 · 3 comments
Open
3 of 6 tasks

Problem with package: cmake #440

henryiii opened this issue Apr 5, 2024 · 3 comments

Comments

@henryiii
Copy link

henryiii commented Apr 5, 2024

Package name

cmake

Package version

3.29.*

PyPI URL

https://pypi.org/project/cmake/

piwheels URL

https://www.piwheels.org/project/cmake/

Python version

  • Python 3.7
  • Python 3.9
  • Python 3.11

I am aware this is the issue tracker for a Python package index specifically for Raspberry Pi

  • Yes

I have checked for duplicate issues

  • Yes

I am the maintainer

  • Yes

More information

The package build is currently broken. scikit-build/cmake-python-distributions#475 The build changed quite a bit, now being based on scikit-build-core instead of scikit-build (classic), which was a setuptools wrapper. I probably could help point out what needs updating if I knew where the build source was.

@bennuttall
Copy link
Member

See the build logs here: https://www.piwheels.org/project/cmake/

Screenshot 2024-04-05 at 9 55 34 am

(click the crosses)

e.g. https://www.piwheels.org/logs/0000/1166/7513.txt

@henryiii
Copy link
Author

henryiii commented Apr 5, 2024

A simple fix would be to skip the one failing permissions test. Needs investigation in CMake, don't think this failure is related to the backend.

The default for making builds is doing to be changing in the 3.29.1 release, you'll need to opt-into running the tests when building the wheel. I assume packagers may want to opt-in, but normal users don't want to run the tests when just building a wheel from an SDist. Not sure if there's a place to add configure-settings or environment variables for the build here.

@bennuttall
Copy link
Member

We can add environment variables if necessary. We could set it here: https://github.com/piwheels/piwheels/blob/master/piwheels/slave/builder.py#L440

Alternatively, you could check if PIWHEELS_BUILD is set and disable the tests.

But I think requiring opt-in for running tests makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants