-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Document New Codemod Preferences #165
Conversation
docs/configuring.md
Outdated
|
||
Setting to `false` disables Pixeebot features that [rely on generative AI](faqs.md) to analyze your code. | ||
|
||
> **Note** Pixeebot uses generative AI by default (`true` by default) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move this line to either be first in this section, or last. (If first, can remove the markdown and make it the first line in that initial paragraph.) Right now it feels a bit disconnected because we talk about false, then true, then show an example of false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I struggled a bit with this. In the current version of the docs, we talk about what setting this AI proeprty to true
does, then at the end of this section we mention "oh by the way, true
is the default". It didn't sit right with me, because it sounds like we're saying "if you do this, then this will happen, but actually that's the default behavior, so if you don't want that then do the opposite of everything I just explained".
So I tried to rewrite it to say "take this action to change the default behavior, and this is the effect". I think your recommendation to simply move the "true
is the default" to be first in the section gets us there. I'm going to make that change now.
|
||
#### `prepend` | ||
|
||
A list of non-default codemods to prepend to the codemod catalog. This list is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended to cover general includes, or is it a separate thing in addition to an include
list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a (documented) include
list. We have an undocumented additional_codemods
list that prepends the list to the default catalog. This new, documented prepend
property supplants the undocumented additional_codemods
property and has the same behavior.
Order matters, so I don't foresee us ever adding a general include
: it's too ambiguous about where the codemods are being inserted into the default catalog. I could see us adding an append
to complement the prepend
.
Adds `codemods.exclude` and `codemods.prepend` to our user facing documentation.
42e5d79
to
be6bcdc
Compare
Adds
codemods.exclude
andcodemods.prepend
to our user facing documentation./close #work