Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dark/light mode style changes #60

Merged
merged 4 commits into from
Sep 6, 2023
Merged

dark/light mode style changes #60

merged 4 commits into from
Sep 6, 2023

Conversation

shehanblast
Copy link
Contributor

No description provided.

terranosaurus
terranosaurus requested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@terranosaurus terranosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this is looking great, just two small issues:

  • It looks like you have the color Neutral 90 mapped to the wrong value. What you have in place now is #2C2541/ Neutral 80. Neutral 90 is #1C1533
  • I don't see the change for link color in light mode to #C10B5E

terranosaurus
terranosaurus previously requested changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@terranosaurus terranosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to the introduction page is broken. Otherwise looks good!
Screenshot 2023-09-01 at 10 56 33 AM

@sip49 sip49 self-requested a review September 6, 2023 05:00
sip49
sip49 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@sip49 sip49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. approved

@sip49
Copy link
Member

sip49 commented Sep 6, 2023

@shehanblast - This PR looks good, but there are now conflicts due to the other merge. Can you please fix? And then we can merge it in.

@shehanblast shehanblast requested a review from sip49 September 6, 2023 05:26
sip49
sip49 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@sip49 sip49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@sip49 sip49 removed the request for review from CRRogo September 6, 2023 05:41
@sip49 sip49 merged commit 5fe4451 into main Sep 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sip49 sip49 sip49 approved these changes

@terranosaurus terranosaurus Awaiting requested review from terranosaurus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shehanblast @sip49 @terranosaurus