Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close-pr count included unsuccessful runs #113

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on Dec 29, 2021

  1. fix: close-pr count included unsuccessful runs

    Changed the result to look at whether the array actually had a length as on testing I found that it always said "1 PRs closed" when closing a failing PR.
    ghinks committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    7b4b086 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2021

  1. fix: array sz zero handling

    assume an array will always be returned
    ghinks committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    1d8146d View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. fix: array sz zero handling

    the array length needs to be checked as an array that is empty will be returned by the reduce and promise all combination
    ghinks committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    e7bdc2a View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2022

  1. fix: grammar

    Change code per suggestions. Using ?
    ghinks committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    798292d View commit details
    Browse the repository at this point in the history
  2. fix: grammar

    Optional chaining was available from node 14 onwards, we still support node 12 and so although I'm happy with the change we would have to stop supporting node 12.
    ghinks committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    ea96251 View commit details
    Browse the repository at this point in the history