Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inactive field creating categories #76

Open
atiro opened this issue Jul 7, 2021 · 1 comment
Open

Inactive field creating categories #76

atiro opened this issue Jul 7, 2021 · 1 comment

Comments

@atiro
Copy link
Contributor

atiro commented Jul 7, 2021

Should a field marked as inactive still create a category if it's associated with it ? E.g.

    - name: contentWarning
      path: $.['contentWarning'][*].apprise
      categories:
          - CONTEXT
      inactive: true

still creates CONTEXT as SchemaFactory doesn't check active status.

(Again, discovered this while swapping files round and again could be argued that it shouldn't be in the category if it's inactive. But it might be useful to be able to turn on and off).

@pkiraly
Copy link
Owner

pkiraly commented Jul 8, 2021

@atiro I think I fixed it. Please check it, and report back that it does what you expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants