Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpt2 support appears missing #41

Open
tmc opened this issue Dec 20, 2023 · 0 comments
Open

gpt2 support appears missing #41

tmc opened this issue Dec 20, 2023 · 0 comments

Comments

@tmc
Copy link

tmc commented Dec 20, 2023

I'm not seeing where the gpt2 model is handled similar to how it is done here: https://github.com/openai/tiktoken/blob/main/tiktoken_ext/openai_public.py#L10

A simple test like:

+func TestGpt2Encoding(t *testing.T) {
+       if _, err := EncodingForModel("gpt2"); err != nil {
+               t.Error(err)
+       }
+}

will fail like so:

--- FAIL: TestGpt2Encoding (0.00s)
    tiktoken_test.go:36: Unknown encoding: gpt2
FAIL
exit status 1
FAIL	github.com/pkoukk/tiktoken-go	0.194s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant