Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkp/pkp-lib#9972 Explicitely define folders with javascript to improv… #4279

Merged
merged 2 commits into from
May 22, 2024
Merged

pkp/pkp-lib#9972 Explicitely define folders with javascript to improv… #4279

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2668f23
pkp/pkp-lib#9972 Explicitely define folders with javascript to improv…
jardakotesovec May 21, 2024
cfa1357
pkp/pkp-lib#9972 Add more folders to jsconfig.json
jardakotesovec May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"compilerOptions": {
"baseUrl": ".",
"paths": {
"@/components/*": ["lib/ui-library/src/components/*"]
"@/*": ["lib/ui-library/src/*"]
}
},
"exclude": ["node_modules"]
"include": ["lib/ui-library/src/**/*", "lib/pkp/js/**/*.js"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anything else need to be included here, e.g. the top level js directory? This includes the build.js and the pkp.min.js but there are also a few legacy controller files. My guess is this is fine since this is all related to our legacy use of JS, but just wanted to double check.

Copy link
Contributor Author

@jardakotesovec jardakotesovec May 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to avoid the 'build' big files.

Add couple more entries - hopefully it covers all the important ones:

	"include": ["lib/ui-library/src/**/*", "lib/pkp/js/**/*.js", "js/controllers/**/*.js", "js/load.js"]

}