-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax editing metadata on published/posted materials #10263
Comments
We had previously relied on the act of publishing (e.g. I would propose a naive approach that simply always dispatches the This approach has the advantage of using already existing events and jobs and allows any updates to happen asynchronously to the web request. It is also extensible for any future services or third-party plugins that need to know when metadata has been updated. Examples of downstream services that would make use of this (either currently implemented or future implementations):
|
@asmecher Ready for review |
Thanks, @Hafsa-Naeem! @Vitaliy-1, would you be able to review this one? |
@asmecher @Hafsa-Naeem On ui-library side of things this make sense to apply to the new side modal workflow page. Trying to get that side modal workflow page as default on main branch ASAP.. Its probably 2-4 weeks away. |
This is a good change, because journals get stuck and create new versions easily without any good reason (correcting a typo etc.) Just asking that when we now edit the metadata, is this visible in the editorial history? ie. do we stamp who did what? I think this is important especially after something has been published. |
There would be an event in the event log, but if the editor chooses not to create a new version, the change will not be tracked. Note that we'll be extending versioning further with #4860 -- description there. |
@Hafsa-Naeem Hi Hafsa, Permission to edit publication is now calculated here - https://github.com/pkp/ui-library/blob/main/src/pages/workflow/composables/useWorkflowPermissions.js#L70 . So that might be only place you need to adjust on frontend. Let me know if you have any difficulties. |
Describe the bug
Currently, when content is published/posted in OJS/OMP/OPS, editors are restricted from making further changes:
In practice, however, editors want the ability to tweak/edit metadata in published content. This has led to anti-patterns like unpublish/edit/republish cycles.
In OMP, there is an additional problem, where certain data on Publication Formats can't be accessed/reviewed because the edit links disappear once the content is published.
Accepting that editors are going to want to tweak metadata after publication, we should keep the warning message present, but stop restricting edits. We should trust the editors to understand the implications of making edits, but not try to prevent it.
The text was updated successfully, but these errors were encountered: