-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REST API should return more information about submission editorial activity #8885
Comments
On the Days in Stage column from @Devika008:
@Devika008 what do you think about using days in round for the review stage? When an editor starts a new round of review, the days in stage goes back to 0. That way, delays due to the author not sending in revisions aren't counted. It's kind of like: days since the editor last took a major decision. |
PRs |
@defstat, I think you have been working on a similar issue, do you have time to review this? To avoid potential performance problems I've used the approach described here: #9394 (reply in thread) |
Reminder to include additional data: reviewer name and submission title |
@defstat, do you have time to review the PR? |
@Vitaliy-1 Would these changes also add reviewer name to the |
@jardakotesovec, I've added the review/stage assignments data to the submission's schema and you reminded me that it's now available not only through |
Opened a separate issue: #9956 |
@jardakotesovec, regarding reviewer name, can you describe in more details where reviewer names would be used? I don't see them originally on the mockups for submission lists. Also, for whom this data should be available? |
@Vitaliy-1 that would be for editors, when they click on 'review assignment' circle to display details of that review assignment. |
@Vitaliy-1 Can you please also include reviewMethod in reviewAssignments for _submission and /submission/{submissionId} endpoints? |
[WIP] #8885 Retrieve review assignments associated with submissions list
Describe the problem you would like to solve
The new submissions lists (#7495) need to show a lot more information about a submission's editorial state. This includes information related to editorial decisions, review round status, and review assignments.
Describe the solution you'd like
The submissions list already makes a lot of database calls for each submission returned. Adding more could significantly slow down the submission dashboard. I don't know the best way to solve this problem, but some ideas:
submission_settings
table.Who is asking for this feature?
This is needed to implement the new submissions table view (#8880) for #7495. Much of this information was the highest priority following user tests.
**Editorial Activity **
The most complicated information to be returned is in the Editorial Activity column (see mockups in #8880). The following table outlines the conditions under which certain data needs to be available.
STATUS_SCHEDULED
. In OJS, it should show the issue it is scheduled in.It may be better to calculate these conditions on the server and return specific data with the API responses. Or it may be better to include the general data (for example, review assignments, round, last decision), and let the UI determine what to show.
Review Assignment Circles
In order to display the review assignment circles, we'll need the following information about each active review assignment (not declined or cancelled):
The text was updated successfully, but these errors were encountered: