Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OMP] Add cover image to ONIX export data #9927

Closed
asmecher opened this issue May 1, 2024 · 6 comments
Closed

[OMP] Add cover image to ONIX export data #9927

asmecher opened this issue May 1, 2024 · 6 comments
Assignees
@kaitlinnewson @pkp-dev-distribution
Milestone
3.3.0-18

Comments

@asmecher
Copy link
Member

asmecher commented May 1, 2024

The book cover image is not currently included in the ONIX extract; DOAB would like it to be added.

DOAB suggests we use the following ONIX field(s):

CollateralDetail/SupportingResource/ResourceVersion/ResourceLink
@kaitlinnewson kaitlinnewson self-assigned this Jun 11, 2024
kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Jun 11, 2024
@kaitlinnewson
pkp/pkp-lib#9927 add cover image to onix export data
c437da0
@kaitlinnewson kaitlinnewson moved this to In Progress in DOAB / OMP Data Exchange Jun 11, 2024
kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Jun 12, 2024
@kaitlinnewson
pkp/pkp-lib#9927 add cover image to onix export data
59eb9f1
kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Jun 12, 2024
@kaitlinnewson
pkp/pkp-lib#9927 add cover image to onix export data
c9f419b
@kaitlinnewson
Copy link
Member

kaitlinnewson commented Jun 12, 2024 •
edited
Loading

Ready for review @asmecher

PRs:

This adds a link to the ONIX export metadata for the cover image URLs. Something to note is that because OMP uses a default placeholder image if no cover is added, the placeholder will be linked to when no cover was uploaded.

@asmecher
Copy link
Member Author

Thanks, @kaitlinnewson! Just one thing to change.

kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Jun 13, 2024
@kaitlinnewson
pkp/pkp-lib#9927 set optional locale param for getLocalizedCoverImageUrl
1285062
@kaitlinnewson
Copy link
Member

@asmecher Ready for a second look in pkp/omp#1583

@asmecher
Copy link
Member Author

That looks great! Could you sync the changes to the other PRs for the other branches?

kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Jun 13, 2024
@kaitlinnewson
pkp/pkp-lib#9927 set optional locale param for getLocalizedCoverImageUrl
61f1933
kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Jun 13, 2024
@kaitlinnewson
pkp/pkp-lib#9927 set optional locale param for getLocalizedCoverImageUrl
a6d7e69
@kaitlinnewson
Copy link
Member

Changes are now synced to the other PRs

asmecher pushed a commit to pkp/omp that referenced this issue Jun 13, 2024
@kaitlinnewson @asmecher
pkp/pkp-lib#9927 add cover image to onix export data
d5ffd4d
asmecher pushed a commit to pkp/omp that referenced this issue Jun 13, 2024
@kaitlinnewson @asmecher
pkp/pkp-lib#9927 set optional locale param for getLocalizedCoverImageUrl
8bd5ffb
asmecher pushed a commit to pkp/omp that referenced this issue Jun 13, 2024
@kaitlinnewson @asmecher
pkp/pkp-lib#9927 add cover image to onix export data
6834a0f
asmecher pushed a commit to pkp/omp that referenced this issue Jun 13, 2024
@kaitlinnewson @asmecher
pkp/pkp-lib#9927 set optional locale param for getLocalizedCoverImageUrl
3e488ad
asmecher pushed a commit to pkp/omp that referenced this issue Jun 13, 2024
@kaitlinnewson @asmecher
pkp/pkp-lib#9927 add cover image to onix export data
275a16d
asmecher pushed a commit to pkp/omp that referenced this issue Jun 13, 2024
@kaitlinnewson @asmecher
pkp/pkp-lib#9927 set optional locale param for getLocalizedCoverImageUrl
b5cc6fe
@asmecher
Copy link
Member Author

Thanks, @kaitlinnewson, I've merged all 3! 🎆

@github-project-automation github-project-automation bot moved this from In Progress to Done in DOAB / OMP Data Exchange Jun 13, 2024
@asmecher asmecher added this to the 3.3.0-18 milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaitlinnewson kaitlinnewson

@pkp-dev-distribution pkp-dev-distribution

Labels
None yet
Projects
DOAB / OMP Data Exchange
Status: Done
Milestone
3.3.0-18
Development

No branches or pull requests
3 participants
@asmecher @kaitlinnewson @pkp-dev-distribution