Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/pkp-lib#10362 include editorName when logging an editorial decision #10628

Open
wants to merge 2 commits into
base: stable-3_4_0
Choose a base branch
from
Open

pkp/pkp-lib#10362 include editorName when logging an editorial decision #10628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8b6d55
pkp/pkp-lib#10362 include editorName when logging an editorial decision
kaitlinnewson Nov 21, 2024
f40bc60
pkp/pkp-lib#10362 update username variable to editorname in locale files
kaitlinnewson Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions classes/decision/Repository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
/**
* @file classes/decision/Repository.php
*
* Copyright (c) 2014-2022 Simon Fraser University
* Copyright (c) 2000-2022 John Willinsky
* Copyright (c) 2014-2024 Simon Fraser University
* Copyright (c) 2000-2024 John Willinsky
* Distributed under the GNU GPL v3. For full terms see the file docs/COPYING.
*
* @class Repository
Expand Down Expand Up @@ -237,6 +237,7 @@ public function add(Decision $decision): int
? PKPSubmissionEventLogEntry::SUBMISSION_LOG_EDITOR_RECOMMENDATION
: PKPSubmissionEventLogEntry::SUBMISSION_LOG_EDITOR_DECISION,
'userId' => Validation::loggedInAs() ?? $this->request->getUser()?->getId(),
'editorName' => $editor->getFullName(),
'message' => $decisionType->getLog(),
'isTranslated' => false,
'dateLogged' => Core::getCurrentDate()
Expand Down Expand Up @@ -378,7 +379,7 @@ abstract public function getDecisionTypes(): Collection;
abstract public function getDeclineDecisionTypes(): array;

/**
* Get a list of the decision types that a recommending user is
* Get a list of the decision types that a recommending user is
* allowed to make given a submission stage id.
*
* @return DecisionType[]
Expand Down
2 changes: 1 addition & 1 deletion locale/ar/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1976,7 +1976,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"المحرر {$userName} قد أكد إجراء الجولة {$round} لتحكيم طلب التقديم "
"المحرر {$editorName} قد أكد إجراء الجولة {$round} لتحكيم طلب التقديم "
"{$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/az/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2101,7 +2101,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"{$userName} adlı redaktor {$submissionId} nömrəli üçün {$round}. tur "
"{$editorName} adlı redaktor {$submissionId} nömrəli üçün {$round}. tur "
"incələməsi üçün bir dəyərləndirmə təsdiqləndi için bir değerlendirme "
"doğruladı."

Expand Down
2 changes: 1 addition & 1 deletion locale/bg/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2065,7 +2065,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"Радакторът {$userName} потвърди рецензията за кръг (етап) {$round} за "
"Радакторът {$editorName} потвърди рецензията за кръг (етап) {$round} за "
"подадените материали {$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/ca/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2025,7 +2025,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"L'editor/a {$userName} ha confirmat una revisió per a la ronda {$round} de "
"L'editor/a {$editorName} ha confirmat una revisió per a la ronda {$round} de "
"revisió de la tramesa {$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/cs/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2026,7 +2026,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"Editor {$userName} potvrdil recenzi pro {$round}. recenzní kolo příspěvku "
"Editor {$editorName} potvrdil recenzi pro {$round}. recenzní kolo příspěvku "
"{$submitId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/da/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2064,7 +2064,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"Redaktør {$userName} har valideret runde {$round}-bedømmelsen i forbindelse "
"Redaktør {$editorName} har valideret runde {$round}-bedømmelsen i forbindelse "
"med indsendelse {$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/de/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2115,7 +2115,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"Redakteur/in {$userName} hat ein Gutachten aus Begutachtungsrunde {$round} "
"Redakteur/in {$editorName} hat ein Gutachten aus Begutachtungsrunde {$round} "
"für die Einreichung {$submissionId} bestätigt."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/en/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1813,7 +1813,7 @@ msgid "log.review.reviewerResendRequest"
msgstr "Resent the request to review in round {$round} to {$reviewerName} for submission {$submissionid}."

msgid "log.review.reviewConfirmed"
msgstr "Editor {$userName} has confirmed a review for the round {$round} review for submission {$submissionId}."
msgstr "Editor {$editorName} has confirmed a review for the round {$round} review for submission {$submissionId}."

msgid "log.review.reviewReady"
msgstr "{$reviewerName} has completed the review for the round {$round} review for submission {$submissionId}."
Expand Down
2 changes: 1 addition & 1 deletion locale/es/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2055,7 +2055,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"El editor/a {$userName} ha confirmado una revisión para la ronda de revisión "
"El editor/a {$editorName} ha confirmado una revisión para la ronda de revisión "
"{$round} del envío {$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/fi/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2060,7 +2060,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"Toimittaja {$userName} on vahvistanut arvion käsikirjoitukselle "
"Toimittaja {$editorName} on vahvistanut arvion käsikirjoitukselle "
"{$submissionId} kierroksella {$round}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/fr_CA/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2137,7 +2137,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"Le,la rédacteur-trice {$userName} a confirmé une évaluation pour le cycle "
"Le,la rédacteur-trice {$editorName} a confirmé une évaluation pour le cycle "
"d'évaluation {$round} pour la soumission {$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/fr_FR/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2098,7 +2098,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"Le rédacteur ou la rédactrice {$userName} a confirmé une évaluation pour le "
"Le rédacteur ou la rédactrice {$editorName} a confirmé une évaluation pour le "
"cycle d'évaluation {$round} pour la soumission {$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/gl/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1911,7 +1911,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"O editor/a {$userName} confirmou unha revisión da rolda de revisión {$round} "
"O editor/a {$editorName} confirmou unha revisión da rolda de revisión {$round} "
"do envío {$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/hr/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2014,7 +2014,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"Urednik {$userName} je potvrdio recenziju za rundu {$round} recenzije za "
"Urednik {$editorName} je potvrdio recenziju za rundu {$round} recenzije za "
"predaju {$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/hu/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1967,7 +1967,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"{$userName} szerkesztőként megerősítette a(z) {$submissionId} beküldés "
"{$editorName} szerkesztőként megerősítette a(z) {$submissionId} beküldés "
"szakmai lektorálását a {$round} számú lektorálási körben."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/hy/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2037,7 +2037,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"{$userName} -ի խմբագիրը հաստատել է {$submissionId} ներկայացման {$round} "
"{$editorName} -ի խմբագիրը հաստատել է {$submissionId} ներկայացման {$round} "
"փուլի գրախոսությունը:"

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/id/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1905,7 +1905,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"Editor {$userName} telah mengonfirmasi review untuk tahap {$round} review "
"Editor {$editorName} telah mengonfirmasi review untuk tahap {$round} review "
"untuk naskah {$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/is/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2018,7 +2018,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"Ristjórinn {$userName} hefur staðfest ritrýni fyrir {$round} umferð "
"Ristjórinn {$editorName} hefur staðfest ritrýni fyrir {$round} umferð "
"innsendingar {$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/it/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2048,7 +2048,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"L'Editor {$userName} ha confermato una revisione per il {$round} ciclo per "
"L'Editor {$editorName} ha confermato una revisione per il {$round} ciclo per "
"il manoscritto {$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/ka/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1997,7 +1997,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"რედაქტორმა {$userName} დაადასტურა მიმოხილვა მიმოხილვაზე მრგვალი {$round} "
"რედაქტორმა {$editorName} დაადასტურა მიმოხილვა მიმოხილვაზე მრგვალი {$round} "
"მიმოხილვა წარდგენისთვის {$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/kk/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1995,7 +1995,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"{$userName} редакторы \"{$submissionId}\" материалы үшін {$round} шолу "
"{$editorName} редакторы \"{$submissionId}\" материалы үшін {$round} шолу "
"кезеңінде шолуды мақұлдады."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/lv/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2252,7 +2252,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"Redaktors {$userName} ir apstiprinājis iesniegtā materiāla {$submissionId} "
"Redaktors {$editorName} ir apstiprinājis iesniegtā materiāla {$submissionId} "
"recenziju {$round}. kārtai."

msgid "submission.review.status.awaitingResponse"
Expand Down
2 changes: 1 addition & 1 deletion locale/mk/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2050,7 +2050,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"Уредникот {$userName} потврди рецензија за {$round} рунда на рецензија за "
"Уредникот {$editorName} потврди рецензија за {$round} рунда на рецензија за "
"поднесокот {$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/ms/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1916,7 +1916,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"Editor {$userName} telah mengesahkan ulasan untuk ulasan pusingan {$round} "
"Editor {$editorName} telah mengesahkan ulasan untuk ulasan pusingan {$round} "
"untuk penyerahan {$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/nb/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1925,7 +1925,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"Redaktøren {$userName} har validert en {$round} runde for innlevering "
"Redaktøren {$editorName} har validert en {$round} runde for innlevering "
"{$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/pt_BR/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2059,7 +2059,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"Editor(a) {$userName} confirmou uma avaliação para a rodada {$round} de "
"Editor(a) {$editorName} confirmou uma avaliação para a rodada {$round} de "
"avaliação para a submissão {$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/pt_PT/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2042,7 +2042,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"O editor {$userName} confirmou uma revisão da ronda de revisão {$round} para "
"O editor {$editorName} confirmou uma revisão da ronda de revisão {$round} para "
"a submissão {$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/ro/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1928,7 +1928,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"Editorul {$userName} a confirmat o revizie pentru runda {$round} pentru "
"Editorul {$editorName} a confirmat o revizie pentru runda {$round} pentru "
"manuscrisul {$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/ru/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2062,7 +2062,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"Редактор {$userName} подтвердил рецензию на раунде {$round} рецензирования "
"Редактор {$editorName} подтвердил рецензию на раунде {$round} рецензирования "
"для материала «{$submissionId}»."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/sl/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2021,7 +2021,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"urednik {$userName} je potrdil recenzijski krog {$round} za prispevek "
"urednik {$editorName} je potrdil recenzijski krog {$round} za prispevek "
"{$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/sv/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2025,7 +2025,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"Redaktören {$userName} har bekräftat granskning av bidraget {$submissionId} "
"Redaktören {$editorName} har bekräftat granskning av bidraget {$submissionId} "
"för granskningsomgång {$round}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/tr/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2016,7 +2016,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"{$userName} adlı editör {$submissionId} nuaralı için {$round}. tur "
"{$editorName} adlı editör {$submissionId} nuaralı için {$round}. tur "
"incelemesi için bir değerlendirme doğruladı."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/uk/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2053,7 +2053,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"Редактор {$userName} підтвердив рецензію для раунду {$round} рецензування "
"Редактор {$editorName} підтвердив рецензію для раунду {$round} рецензування "
"для подання {$submissionId}."

msgid "log.review.reviewReady"
Expand Down
2 changes: 1 addition & 1 deletion locale/vi/submission.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1899,7 +1899,7 @@ msgstr ""

msgid "log.review.reviewConfirmed"
msgstr ""
"Biên tập viên {$userName} đã xác nhận một đánh giá trong vòng phản biện "
"Biên tập viên {$editorName} đã xác nhận một đánh giá trong vòng phản biện "
"{$round} của bài {$submitId}."

msgid "log.review.reviewReady"
Expand Down