-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDX-84: Add test environments #60
base: main
Are you sure you want to change the base?
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
- name: Init test database | ||
run: docker compose up -d | ||
|
||
- name: Wait for database | ||
run: docker compose exec db bash -c 'while ! pg_isready -h localhost -p 5432 -U postgres; do sleep 1; done;' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works, it seems okay to merge 👍🏻 As a note, I remember there is a service container feature in the GitHub Actions service. It would be nice to see if it's a good idea to utilize this feature in the future when you have some free time.
https://docs.github.com/en/actions/using-containerized-services/about-service-containers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there are some errors while running Postgres database.
⎯⎯⎯⎯⎯⎯ Unhandled Error ⎯⎯⎯⎯⎯⎯⎯
Error: EACCES: permission denied, scandir '/home/runner/work/9c-rudolf/9c-rudolf/.test/db'
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { errno: -13, code: 'EACCES', syscall: 'scandir', path: '/home/runner/work/9c-rudolf/9c-rudolf/.test/db' }
I'm handling this issue and think service container feature can be help this issue. Thank you for your information! |
No description provided.