-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/synthesize #6537
Open
eugene-doobu
wants to merge
29
commits into
development
Choose a base branch
from
feature/synthesize
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/synthesize #6537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…size # Conflicts: # nekoyume/Assets/_Scripts/Lib9c/lib9c
…size # Conflicts: # nekoyume/Assets/_Scripts/Lib9c/lib9c
eugene-doobu
requested review from
sonohoshi and
jonny-jeahyunchoi
as code owners
December 3, 2024 04:54
Open
@eugene-doobu The versions of bundled Libplanet assemblies and Libplanet submodule vendored by Lib9c apparently do not match:
Leave a comment in this pull_request with the following command to let the bot upgrade bundled Libplanet assemblies:
|
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synthesis 관련 UI 기반 작업입니다.
아직 모든 작업이 완료된건 아니며 다음 작업은 아래 이슈로 Synthesis 클래스의 OnClickGradeItem 구현을 채워놓는 것으로 시작 할 예정입니다. 해당 작업을 포함하여 기본 작업에서 추가 작업이 필요한 부분은 TODO 코멘트 달아두었습니다.
#6502