Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special Handling Required for WorldBossKillRewardSheet and WorldBossBattleRewardSheet in PatchTableHandler #50

Open
Atralupus opened this issue May 10, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Atralupus
Copy link
Member

Atralupus commented May 10, 2024

In the this code, the conditional statement if (sheetType == typeof(WorldBossKillRewardSheet) || sheetType == typeof(WorldBossBattleRewardSheet)) excludes these two sheets because they require a special treatment before accessing their Rune values. The SetRune method must be called first to avoid errors.

We need to handle these two sheets specifically within this code using reflection. Currently, they are excluded from processing. Finding a clean way to handle these sheets properly without excluding them will be essential.

@Atralupus Atralupus self-assigned this May 10, 2024
@Atralupus Atralupus moved this from In Progress to Todo in Nine Chronicles DX Team Jul 8, 2024
@Atralupus Atralupus added the bug Something isn't working label Jul 9, 2024
@Atralupus Atralupus added this to the Mimir Q3 milestone Jul 9, 2024
@Atralupus Atralupus changed the title Special Handling Required for WorldBossKillRewardSheet and WorldBossBattleRewardSheet in TableSheetScrapper Special Handling Required for WorldBossKillRewardSheet and WorldBossBattleRewardSheet in PatchTableHandler Sep 3, 2024
@Atralupus Atralupus removed this from the Mimir Q3 milestone Sep 3, 2024
@Atralupus Atralupus removed their assignment Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant