Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display crop names as tabs in the Dataset Explorer #467

Closed
Don-Isdale opened this issue Dec 17, 2024 · 2 comments
Closed

Display crop names as tabs in the Dataset Explorer #467

Don-Isdale opened this issue Dec 17, 2024 · 2 comments
Assignees
@Don-Isdale

Comments

@Don-Isdale
Copy link
Collaborator

part of #465

Display crop (group) names as tabs in the Dataset Explorer
@Don-Isdale Don-Isdale self-assigned this Dec 17, 2024
@Don-Isdale Don-Isdale mentioned this issue Dec 17, 2024
Open
Don-Isdale added a commit that referenced this issue Jan 2, 2025
@Don-Isdale
Display Crop Selector
8e4d0e5 
part of #465 : #466, #467.
manage-explorer.js :
 dataPre1() : insert filter by .cropFilterSelected.
 dataPre() : rename to dataPostNameFilter, and use alias to define it, so that filters can be inserted easily (dataPre is used in several places); e.g. dataPostCrop() was drafted to implement the crop filter, which is now implemented in dataPre1(), upstream of the name filter, whereas dataPre is downstream of the name filter, as indicated by the name dataPostNameFilter.
 add noCrop, cropFilterSelected, selectedCropChanged, cropField, withCrop, child1Crop, cropNames (these are based on respectively noGroup, groupFilterSelected, selectedGroupChanged, withParent, child1, parents, parentNames, substituting parent → crop).
 add cropsForFilter.

dataset.js : add cropName : alias(_meta.Crop).
filter-group.js : toString() : reduce trace.
manage-explorer.hbs : Use form/select-group, with .cropFilterSelected, .cropsForFilter, .selectedCropChanged
@Don-Isdale
Copy link
Collaborator Author

Posted for discussion in Project / User channel

In #302 / #465, the Crop selection can be via radio button or a pull-down similar to Group.
I think making it like Group makes the GUI visually simpler, and changing between 'All' and a selected Crop is simple.
I'll start on that; feedback welcome. (I think I can factor to re-use the Group selector.)
BTW, the Crop selector can be either before or after the 'Search All Datasets' filter; the Group selector is before, so placing it with Group would be visually appealing. The semantics are similar, and changing it is not a large effort.

Functionality added

8e4d0e5 Display Crop Selector

Tested on local

These tests include a display of the list of crop names, which was used in development and dropped before the commit.

Screenshot from 2025-01-02 14-05-16
Screenshot from 2025-01-02 14-06-21

@Don-Isdale Don-Isdale mentioned this issue Jan 2, 2025
Closed
@Don-Isdale
Copy link
Collaborator Author

Testing on local after commit

These screenshots show the result after removing the development display of the crop name list.

Screenshot from 2025-01-02 16-02-41

This screenshot shows the interaction with the Group selector.

Screenshot from 2025-01-02 16-02-15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Don-Isdale Don-Isdale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Don-Isdale