Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve 'Show Logs' issue by adding _xsrf token #61

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Resolve 'Show Logs' issue by adding _xsrf token #61

merged 2 commits into from
Nov 17, 2023

Conversation

yamaton
Copy link
Contributor

@yamaton yamaton commented Nov 9, 2023

Fix #60.

@yamaton yamaton changed the title Fix "Show Logs" due to missing _xsrf token in JupyterHub 4 Resolve 'Show Logs' issue by adding _xsrf token in JupyterHub 4 Nov 9, 2023
@yamaton yamaton changed the title Resolve 'Show Logs' issue by adding _xsrf token in JupyterHub 4 Resolve 'Show Logs' issue by adding _xsrf token Nov 9, 2023
@pierrepo
Copy link
Contributor

@jtpio would you mind review this PR?

@jtpio
Copy link
Member

jtpio commented Nov 16, 2023 •
edited
Loading

CI failure looks unrelated and likely due to the Notebook 7 release:

ERROR  - ModuleNotFoundError: No module named 'notebook.notebookapp'

Edit: investigating in #62

@jtpio jtpio mentioned this pull request Nov 16, 2023
Merged
@jtpio jtpio added the bug Something isn't working label Nov 16, 2023
@jtpio
Copy link
Member

jtpio commented Nov 16, 2023

Merging the main branch to grab the CI fix from #62.

jtpio
jtpio approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit c42f08a into plasmabio:master Nov 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Show Logs" fails due to missing _xsrf token with JupyterHub 4
3 participants
@yamaton @pierrepo @jtpio