Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play Framework 2.5 support is needed #308

Open
realzeus opened this issue May 3, 2016 · 14 comments
Open

Play Framework 2.5 support is needed #308

realzeus opened this issue May 3, 2016 · 14 comments
Assignees

Comments

@realzeus
Copy link

realzeus commented May 3, 2016

play2war currently does not support play 2.5.

@masudjbd
Copy link

when play 2.5 version will be available?

@victorjussiani
Copy link

+1

@litts
Copy link

litts commented Jun 11, 2016

+1 upgraded to 2.5 but can't deploy to client have to revert back

@pdenc
Copy link

pdenc commented Jun 17, 2016

When play 2.5 version will be available?

@mwiley63
Copy link

+1 I would really like to utilize the custom logging framework in 2.5 in a Tomcat environment. https://www.playframework.com/documentation/2.5.x/SettingsLogger#using-a-custom-logging-framework

@kbarzen-idn
Copy link

kbarzen-idn commented Jun 30, 2016

Any idea when it's compatible with Play 2.5? Is it already scheduled?

@yanns
Copy link
Member

yanns commented Jun 30, 2016

Thanks all of us for manifesting interest!
The play2war is completely depending on free time of some people (like me).
I do not have the time/motivation to make this change now.
If one of you want to try, I'd be glad to assist.

@yanns yanns self-assigned this Aug 31, 2016
@cyrilfr
Copy link

cyrilfr commented Feb 1, 2017

@yanns Hi, I could try to do it depending on how much work it represents.

@yanns
Copy link
Member

yanns commented Feb 2, 2017

@cyrilfr thx for the proposition.
Look at https://github.com/play2war/play2-war-plugin/wiki/How-to-help for some general information.

How you can proceed:

  • you can start from the in progress implementation: https://github.com/play2war/play2-war-plugin/tree/308_play_2.5.
  • the first step is to make the project_code compiling so that you can deploy a local version of the sbt plugin. The not-implemented features can be added after.
  • then you can change the play application in sample to use your local version and generate a war of it.
  • finally, you can run the integration tests.
  • iterate on that: improve project_code, make more tests passing... ;)

To improve project_code, you can have a look at the sources of the play framework, especially:

The servlet 3.1 implementation is an optimized version (using non blocking IO) and can be done at the end: dae86f0#diff-6631fbdeb8bfe668903b928d15152696L153

For a faster iteration loop, you can use the aliases defined in https://github.com/play2war/play2-war-plugin/blob/308_play_2.5/project-code/.sbtrc
In my experience, in sample, you have to exit sbt to be able to use the last version.

@at-tantv
Copy link

at-tantv commented Jul 6, 2017

I need it now, so when you free time you can support for me

@jroper
Copy link

jroper commented Jan 2, 2018

For anyone wishing to take this up, I've implemented a servlet 3.1 based reactive streams implementation that can be used to bridge to Akka streams in Play 2.5. I've verified it against both Tomcat and Jetty.

@yanns
Copy link
Member

yanns commented Jan 6, 2018

Thanks a lot @jroper !!

To whoever is interested, it should be much easier now to bind play and a servlet container.
I can offer some support.

@pwyczes
Copy link
Contributor

pwyczes commented Jul 1, 2018

Hi there, I started to work on #321 (play 2.6) so if anyone is willing to help me with that (or at least comment if I am moving in the right direction), I will be more than happy. :)

PS.
Thanks @yanns for your work on play 2.5 - it helped me a lot.

@pwyczes
Copy link
Contributor

pwyczes commented Jul 27, 2018

Hi @yanns, as I wrote, I am working on #321 (play 2.6).
If you still can offer some support, maybe you can give me some hints on #323 ;) I would appreciate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests