Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove android_library wrapping of Android Player #438

Open
brocollie08 opened this issue Jul 19, 2024 · 0 comments
Open

Remove android_library wrapping of Android Player #438

brocollie08 opened this issue Jul 19, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@brocollie08
Copy link
Contributor

kt_android_library from Kotlin rules as it stands is insufficient for creating an AAR with the android manifest included, the result of that is broken distribution of the AAR produced by it.

The current workaround is to manually wrap the output of kt_android_library with native android_library, this can be levelled to the Kotlin rules, so we don't have to do manual work from our end to achieve this.

@brocollie08 brocollie08 added enhancement New feature or request good first issue Good for newcomers labels Jul 19, 2024
@KetanReddy KetanReddy added this to the 1.0 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants