Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear registry when transitioning to non view state #564

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nancywu1
Copy link
Contributor

@nancywu1 nancywu1 commented Dec 18, 2024

When going from a view state to an external state to another view state, the content from first view shows momentarily before showing content of new view state, by resetting the view we prevent this from happening

similar behaviour occurs when a view going to an END state and shows a modal and previous view is still present before showing new content

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs
📦 Published PR as canary version: 0.10.1--canary.564.18899

Try this version out locally by upgrading relevant packages to 0.10.1--canary.564.18899

@nancywu1
Copy link
Contributor Author

/canary

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.70%. Comparing base (dc3c3ab) to head (3ab1456).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #564   +/-   ##
=======================================
  Coverage   89.70%   89.70%           
=======================================
  Files         331      331           
  Lines       19794    19804   +10     
  Branches     1948     1949    +1     
=======================================
+ Hits        17756    17766   +10     
  Misses       2024     2024           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant