Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgo_library adds -Wno-error #149

Open
peterebden opened this issue Jul 17, 2023 · 0 comments · May be fixed by #169
Open

cgo_library adds -Wno-error #149

peterebden opened this issue Jul 17, 2023 · 0 comments · May be fixed by #169

Comments

@peterebden
Copy link
Contributor

This appears to be unconditional here.
There's no way to get around it because it's added after cflags so even if I pass -Werror it undoes it again.

Ideally we'd remove this and just have the minimal amount of stuff needed to make it go.

@izissise izissise linked a pull request Oct 26, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant