Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps on go_repo() are not added to the generated cgo_library() #303

Open
sfirmery opened this issue Oct 22, 2024 · 0 comments
Open

Deps on go_repo() are not added to the generated cgo_library() #303

sfirmery opened this issue Oct 22, 2024 · 0 comments

Comments

@sfirmery
Copy link
Contributor

I'm trying to build a static go_binary() that use a go library (github.com/GRbit/go-pcre) that use cgo.

I put the c_library() of libpcre as a dependency of the go_repo(), patched go_repo() to use it instead relying on pkg-config, but the generated BUILD file in this subrepo did not contains the dependency in the cgo_library() and make it fail with a missing header.

I managed to make it works by manually add the c_library() dependency to the cgo_library() in the BUILD file in plz-out/subrepos/third_party/go/github.com_GRbit_go-pcre/BUILD.

Can please_go add this dependency automatically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant