Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up stale packages one by one #1367

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

Danielius1922
Copy link
Member

No description provided.

Copy link
Contributor

coderabbitai bot commented Sep 3, 2024

Walkthrough

The changes introduce a new required input parameter, package_name, to the GitHub Actions workflow, allowing targeted deletion of specific packages instead of a broad category. Additionally, a matrix strategy is implemented in another workflow to enable simultaneous processing of multiple package names, enhancing efficiency through batch operations for stale image cleanup.

Changes

Files Change Summary
.github/actions/cleanup-stale/action.yaml Added inputs.package_name as a required input; modified image names to use ${{ inputs.package_name }}.
.github/workflows/ghcr-cleanup.yaml Introduced a matrix strategy for handling multiple package names, allowing batch deletion of stale images.

Poem

🐰 In the meadow where packages play,
A new name to clean, hip-hip-hooray!
With a hop and a skip, we tidy the space,
Deleting the stale, we quicken the pace.
For every package, we now have a say,
A cleaner world, come join the ballet! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Danielius1922 Danielius1922 force-pushed the adam/feature/fix-package-job branch 3 times, most recently from 5d0209d to 60f7372 Compare September 4, 2024 10:54
@Danielius1922 Danielius1922 changed the title Delete test-cloud-server package Clean-up stale packages one by one Sep 4, 2024
@Danielius1922 Danielius1922 marked this pull request as ready for review September 4, 2024 11:00
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a2762db and 60f7372.

Files selected for processing (2)
  • .github/actions/cleanup-stale/action.yaml (3 hunks)
  • .github/workflows/ghcr-cleanup.yaml (3 hunks)
Additional comments not posted (8)
.github/actions/cleanup-stale/action.yaml (4)

6-8: LGTM!

The new required input parameter package_name is correctly defined.


29-29: LGTM!

The image-names parameter is correctly modified to use the new package_name input.


58-58: LGTM!

The package_name parameter is correctly added to the delete-untagged-ghcr-action action.


Line range hint 1-60: LGTM!

The changes are correctly implemented and consistent with the introduction of the new package_name input parameter. The AI-generated summary accurately describes the changes.

.github/workflows/ghcr-cleanup.yaml (4)

55-77: LGTM!

The matrix strategy is correctly defined and includes a comprehensive list of package names. The fail-fast: false setting is appropriate to ensure that the workflow continues to run even if one of the jobs fails.


87-87: LGTM!

The usage of the package_name matrix variable is correct and ensures that the correct package name is passed to the cleanup action.


93-93: LGTM!

The usage of the package_name matrix variable is correct and ensures that the correct package name is passed to the cleanup action.


102-102: LGTM!

The usage of the package_name matrix variable is correct and ensures that the correct package name is passed to the cleanup action.

@Danielius1922 Danielius1922 force-pushed the adam/feature/fix-package-job branch from 60f7372 to 8b587d6 Compare September 4, 2024 17:04
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 60f7372 and 8b587d6.

Files selected for processing (2)
  • .github/actions/cleanup-stale/action.yaml (3 hunks)
  • .github/workflows/ghcr-cleanup.yaml (3 hunks)
Files skipped from review as they are similar to previous changes (2)
  • .github/actions/cleanup-stale/action.yaml
  • .github/workflows/ghcr-cleanup.yaml

Copy link

sonarcloud bot commented Sep 4, 2024

@Danielius1922 Danielius1922 merged commit 5091170 into main Sep 4, 2024
41 checks passed
@Danielius1922 Danielius1922 deleted the adam/feature/fix-package-job branch September 4, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant