Implement Certificate Revocation List #1379
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Danielius1922
force-pushed
the
adam/feature/crl
branch
from
5ab9db9 to
68ca5a5
Compare
Danielius1922
force-pushed
the
adam/feature/crl
branch
5 times, most recently
from
549b38e to
2c958e9
Compare
Danielius1922
force-pushed
the
adam/feature/crl
branch
4 times, most recently
from
3909233 to
1be10f8
Compare
Danielius1922
force-pushed
the
adam/feature/crl
branch
from
af98bb6 to
bf38565
Compare
| import "strings" | ||
|
|
||
| const ( | ||
| API string = "/api/v1" |
There was a problem hiding this comment.
TODO: add /certificate-authority prefix
Danielius1922
force-pushed
the
adam/feature/crl
branch
from
efac6aa to
8983328
Compare
| @@ -48,6 +48,7 @@ apis: | |||
| tokenTrustVerification: | |||
| cacheExpiration: 30s | |||
| http: | |||
| externalAddress: "https://0.0.0.0:9101" | |||
There was a problem hiding this comment.
set to empty string as in coap gw -> you can add comment line about the format.
| { | ||
| name: "Valid credential", | ||
| input: &pb.CredentialStatus{ | ||
| Date: 1659462400000000000, |
There was a problem hiding this comment.
this is ValidFromDate or it is date when record has been created/updated ?
There was a problem hiding this comment.
The second, it is the record itself as been created or updated
| } | ||
| signer := requestHandler.cas.GetSigner() | ||
| _, validFor := signer.GetCRLConfiguation() | ||
| rl, err := requestHandler.tryGetRevocationList(r.Context(), issuerID, validFor, 3) |
Danielius1922
force-pushed
the
adam/feature/crl
branch
from
00a37d1 to
cf2a07b
Compare
Danielius1922
force-pushed
the
adam/feature/crl
branch
from
cf2a07b to
287679e
Compare
|
This pull request includes several changes to the certificate authority's codebase, focusing on improving the handling of signing records and enhancing documentation. The most important changes include adding validation for
CredentialStatus, updating documentation to reflect the new functionality, and correcting typographical errors.Code Enhancements:
certificate-authority/pb/signingRecords.go: Added aValidatemethod toCredentialStatusto ensure all necessary fields are populated and correctly formatted.certificate-authority/pb/signingRecords.go: RefactoredValidatemethod inSigningRecordto use the newCredentialStatusvalidation.Documentation Updates:
certificate-authority/pb/README.md: Updated descriptions forGetSigningRecordsandDeleteSigningRecordsto reflect the new functionality of revoking certificates. Added fieldsserialandissuer_idto the documentation. [1] [2] [3]certificate-authority/pb/doc.html: Updated HTML documentation to include new fields and corrected descriptions forGetSigningRecordsandDeleteSigningRecords. [1] [2] [3]Typographical Corrections:
certificate-authority/pb/service.proto: Corrected typos in comments forGetSigningRecordsandDeleteSigningRecords. [1] [2]certificate-authority/pb/service.swagger.json: Corrected typos in the Swagger documentation forGetSigningRecordsandDeleteSigningRecords. [1] [2]Minor Changes:
.dockerignore: Addedtest-localto the ignore list.certificate-authority/config.yaml: Removed bulk write configuration settings.These changes collectively enhance the robustness of the certificate authority's functionality and improve the clarity of its documentation.